Skip to content

test: skip test-runner-watch-mode on IBMi - #48473

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-ibmi
Jun 21, 2023
Merged

test: skip test-runner-watch-mode on IBMi#48473
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-ibmi

Conversation

@MoLow

@MoLowMoLow commented Jun 16, 2023

Copy link
Copy Markdown
Member

@nodejs-github-bot

nodejs-github-bot commented Jun 16, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 16, 2023
@MoLow

MoLow commented Jun 16, 2023

Copy link
Copy Markdown
MemberAuthor

CC @nodejs/platform-ibmi

@abmusse

abmusse commented Jun 16, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@MoLow

Thanks for pointing out that fs.watch is not supported on IBM i.

I've been trying to search on the repo and find technical reason why its unsupported by searching with:

https://github.com/nodejs/node/issues?q=fs.watch+ibmi

I haven't found much info on the reason its unsupported yet.

Is fs.watchFile also not supported?

The test case test-runner-watch-mode uses node --watch , Which API does that use (watch or watchFIle)?

@MoLow

MoLow commented Jun 18, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I've been trying to search on the repo and find technical reason why its unsupported by searching with:

I would assume that it is not implemented in libuv, but I was only able to find this #30819

The test case test-runner-watch-mode uses node --watch , Which API does that use (watch or watchFIle)?

it uses watch

node/lib/internal/watch_mode/files_watcher.js

Line 96 in ca71ae6

constwatcher=watch(path,{ recursive,signal: this.#signal });

@abmusse

abmusse commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Thanks for the additional info!

I agree since its using watch API and that is unsupported on IBM i we should skip this test.

@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52308/

@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52313/

@richardlaurichardlau added the ibm i Issues and PRs related to the IBM i platform. label Jun 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52315/

@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52318/

@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52322/

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 0afd6e8 into nodejs:mainJun 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0afd6e8

This was referenced Jun 23, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@MoLow@RafaelGSS
test: skip test-runner-watch-mode on IBMi
09af579
PR-URL: #48473
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow@Ceres6
test: skip test-runner-watch-mode on IBMi
c645ede
PR-URL: nodejs#48473
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow@Ceres6
test: skip test-runner-watch-mode on IBMi
6dda945
PR-URL: nodejs#48473
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
@MoLow@ruyadorno
test: skip test-runner-watch-mode on IBMi
0c195f4
PR-URL: #48473
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@ruyadornoruyadorno mentioned this pull request Sep 10, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@MoLow@ruyadorno
test: skip test-runner-watch-mode on IBMi
8fdd4c5
PR-URL: #48473
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@MoLow
MoLow deleted the fix-ibmi branch May 24, 2024 09:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@LinkgoronLinkgoronLinkgoron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ibm iIssues and PRs related to the IBM i platform.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ibmi: parallel/test-runner-watch-mode fails with timeout

6 participants

@MoLow@nodejs-github-bot@abmusse@Linkgoron@lpinca@richardlau