Skip to content

tools: replace sed with perl - #48499

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:fix/issue-48496
Jun 20, 2023
Merged

tools: replace sed with perl#48499
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:fix/issue-48496

Conversation

@lpinca

@lpincalpinca commented Jun 19, 2023

Copy link
Copy Markdown
Member

For cross-platform compatibility use perl instead of sed.

Fixes: #48496

@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 19, 2023
@lpinca
tools: replace sed with perl
a28f37b
For cross-platform compatibility use perl instead of sed.
Fixes: nodejs#48496
marco-ippolito
marco-ippolito approved these changes Jun 19, 2023
View reviewed changes

@marco-ippolitomarco-ippolito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnelljasnell added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 20, 2023
@github-actions

github-actionsBot commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e7646a5 into nodejs:mainJun 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in e7646a5

@lpinca
lpinca deleted the fix/issue-48496 branch June 20, 2023 12:56
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@lpinca@RafaelGSS
tools: replace sed with perl
4345526
For cross-platform compatibility use perl instead of sed.
Fixes: #48496
PR-URL: #48499
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca@Ceres6
tools: replace sed with perl
ebd7318
For cross-platform compatibility use perl instead of sed.
Fixes: nodejs#48496
PR-URL: nodejs#48499
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca@Ceres6
tools: replace sed with perl
00424af
For cross-platform compatibility use perl instead of sed.
Fixes: nodejs#48496
PR-URL: nodejs#48499
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
@lpinca@ruyadorno
tools: replace sed with perl
38fb350
For cross-platform compatibility use perl instead of sed.
Fixes: #48496
PR-URL: #48499
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadornoruyadorno mentioned this pull request Sep 10, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@lpinca@ruyadorno
tools: replace sed with perl
9711bc2
For cross-platform compatibility use perl instead of sed.
Fixes: #48496
PR-URL: #48499
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
+2 more reviewers
@MesteeryMesteeryMesteery approved these changes
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automated ICU update workflow failed

10 participants

@lpinca@nodejs-github-bot@jasnell@cjihrig@richardlau@RafaelGSS@marco-ippolito@Mesteery@VoltrexKeyva@targos