Skip to content

deps: update icu to 73.2 - #48502

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-icu
Jun 23, 2023
Merged

deps: update icu to 73.2#48502
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-icu

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of icu to 73.2.

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Jun 20, 2023
@debadree25debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2023

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@richardlau

Copy link
Copy Markdown
Member

There are a large number of whitespace only changes, I think originating from #47456 (comment). Hopefully now we have automation in place to do the updates this should be less of an issue in the future.

@richardlaurichardlau removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2023
@marco-ippolito

Copy link
Copy Markdown
Member

do we still need to update thetz-version.txt manually?

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2023
@richardlau

Copy link
Copy Markdown
Member

do we still need to update thetz-version.txt manually?

Only if tzdata has been updated in the ICU release (which I don't think it has for this one).

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit cd28ebb into mainJun 23, 2023
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-icu branch June 23, 2023 13:50
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

Landed in cd28ebb

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48502
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
@kasicka

Copy link
Copy Markdown

Any reason why this was changed back from zip to tgz?

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48502
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48502
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
PR-URL: #48502
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@ruyadornoruyadorno mentioned this pull request Sep 10, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48502
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@nodejs-github-bot@richardlau@marco-ippolito@kasicka@lpinca@aymen94@debadree25