Skip to content

deps: upgrade to libuv 1.46.0 - #48618

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
santigimeno:santi/libuv-v1.46.0
Jul 2, 2023
Merged

deps: upgrade to libuv 1.46.0#48618
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
santigimeno:santi/libuv-v1.46.0

Conversation

@santigimeno

@santigimenosantigimeno commented Jun 30, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@santigimeno
deps: upgrade to libuv 1.46.0
9a5fa6f
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012
Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
@santigimenosantigimeno self-assigned this Jun 30, 2023
@nodejs-github-botnodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Jun 30, 2023
@santigimenosantigimeno added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52570/

@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52575/

@github-actionsgithub-actionsBot mentioned this pull request Jul 1, 2023
Open
30 tasks
@santigimenosantigimeno added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2023
@github-actionsgithub-actionsBot mentioned this pull request Jul 2, 2023
Open
27 tasks
@richardlaurichardlau mentioned this pull request Jul 2, 2023
Closed
@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 2, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 2, 2023
@nodejs-github-bot
nodejs-github-bot merged commit acf071e into nodejs:mainJul 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 2, 2023

Copy link
Copy Markdown
Collaborator

Landed in acf071e

@github-actionsgithub-actionsBot mentioned this pull request Jul 3, 2023
Open
24 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@santigimeno@RafaelGSS
deps: upgrade to libuv 1.46.0
6199e19
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012
Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
PR-URL: #48618Fixes: #48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request Jul 4, 2023
Open
22 tasks
@bmuenzenmeyerbmuenzenmeyer mentioned this pull request Jul 4, 2023
Closed
@github-actionsgithub-actionsBot mentioned this pull request Jul 7, 2023
Open
20 tasks
@GrmiadeGrmiade mentioned this pull request Jul 7, 2023
Closed
This was referenced Jul 8, 2023
Open
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@santigimeno@Ceres6
deps: upgrade to libuv 1.46.0
a2f18db
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012
Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
PR-URL: nodejs#48618Fixes: nodejs#48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@santigimeno@Ceres6
deps: upgrade to libuv 1.46.0
f44cbfc
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012
Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
PR-URL: nodejs#48618Fixes: nodejs#48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
arsnyder16 pushed a commit to arsnyder16/node that referenced this pull request Sep 10, 2023
@santigimeno@arsnyder16
deps: upgrade to libuv 1.46.0
0c99404
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012
Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
PR-URL: nodejs#48618Fixes: nodejs#48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@arsnyder16arsnyder16 mentioned this pull request Sep 10, 2023
Closed
@ruyadorno

ruyadorno commented Sep 11, 2023

Copy link
Copy Markdown
Member

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

@richardlau

richardlau commented Sep 11, 2023

Copy link
Copy Markdown
Member

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

#49591

ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@santigimeno@ruyadorno
deps: upgrade to libuv 1.46.0
8af0d8c
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012
Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
PR-URL: #48618
Backport-PR-URL: #49591Fixes: #48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@santigimeno@ruyadorno
deps: upgrade to libuv 1.46.0
0ed29c0
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012
Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
PR-URL: #48618
Backport-PR-URL: #49591Fixes: #48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@santigimeno@ruyadorno
deps: upgrade to libuv 1.46.0
88855e0
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012
Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
PR-URL: #48618
Backport-PR-URL: #49591Fixes: #48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #48078
@richardlaurichardlau mentioned this pull request Oct 4, 2023
Closed
@legendecaslegendecas mentioned this pull request Mar 13, 2024
Merged
4 tasks
@nbspnbsp mentioned this pull request Apr 12, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@santigimenosantigimeno

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.libuvIssues and PRs related to the libuv dependency or the uv binding.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@santigimeno@nodejs-github-bot@ruyadorno@richardlau@lpinca@anonrig@cjihrig@VoltrexKeyva