Skip to content

[v18.x backport] test_runner: align stdout and std error with and without --test - #48684

Closed
MoLow wants to merge 4 commits into
nodejs:v18.x-stagingfrom
MoLow:backport-align-stdout
Closed

[v18.x backport] test_runner: align stdout and std error with and without --test#48684
MoLow wants to merge 4 commits into
nodejs:v18.x-stagingfrom
MoLow:backport-align-stdout

Conversation

@MoLow

@MoLowMoLow commented Jul 6, 2023•
edited
Loading

Copy link
Copy Markdown
Member

backport of #48057, #48034 and #48428

@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x labels Jul 6, 2023
@MoLowMoLow changed the title lib: support FORCE_COLOR for non TTY streams[v18.x backport] test_runner: align stdout and std error with and without --testJul 6, 2023
@MoLowMoLow mentioned this pull request Jul 9, 2023
Closed
@MoLow
MoLowforce-pushed the backport-align-stdout branch 2 times, most recently from 2042910 to 1ac9c1dCompareJuly 9, 2023 19:20
MoLow added 4 commits July 9, 2023 22:24
@MoLow
lib: support FORCE_COLOR for non TTY streams
b23dcb9
PR-URL: nodejs#48034
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow
test_runner: pass FORCE_COLOR to child process
12bb570
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow
test_runner: dont split lines on test:stdout
d0a39ca
@MoLow
test_runner: add enqueue and dequeue events
c8cd582
PR-URL: nodejs#48428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow
MoLowforce-pushed the backport-align-stdout branch from 1ac9c1d to c8cd582CompareJuly 9, 2023 19:26
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2023
@MoLow
MoLow requested a review from danielleadamsJuly 9, 2023 19:28
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52671/

@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52677/

@nodejs-github-bot

nodejs-github-bot commented Jul 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52679/

@nodejs-github-bot

nodejs-github-bot commented Jul 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52683/

@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52690/

@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52693/

@danielleadams

danielleadams commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

@MoLow does d0a39ca have a PR associated?

@MoLow

MoLow commented Jul 12, 2023

Copy link
Copy Markdown
MemberAuthor

@MoLow does d0a39ca have a PR associated?

@danielleadams , yes. It is https://github.com/nodejs/node/pull/48057/commits which contains two commits

danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow@danielleadams
lib: support FORCE_COLOR for non TTY streams
c46b31f
PR-URL: #48034
Backport-PR-URL: #48684
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow@danielleadams
test_runner: pass FORCE_COLOR to child process
04eb1f8
PR-URL: #48057
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow@danielleadams
test_runner: dont split lines on test:stdout
d795c0a
PR-URL: #48057
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow@danielleadams
test_runner: add enqueue and dequeue events
5d910ca
PR-URL: #48428
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams

danielleadams commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

Landed in a2bfe02...5d910ca

@MoLow
MoLow deleted the backport-align-stdout branch July 12, 2023 12:04
@richardlaurichardlau mentioned this pull request Jan 7, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@danielleadamsdanielleadamsdanielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MoLow@nodejs-github-bot@danielleadams