Uh oh!
There was an error while loading. Please reload this page.
doc: keep the names in sorted order - #4876
Closed
thefourtheye wants to merge 1 commit into
Closed
Conversation
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues
bnoordhuis
commented
Jan 26, 2016
Member
LGTM |
2 similar comments
r-52
commented
Jan 26, 2016
Contributor
LGTM |
cjihrig
commented
Jan 26, 2016
Contributor
LGTM |
silverwind pushed a commit
that referenced
this pull request
Jan 26, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
silverwind
commented
Jan 26, 2016
Contributor
Thanks! Landed in 0a1859d. |
rvagg pushed a commit
that referenced
this pull request
Jan 27, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
benjamingr pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: nodejs#4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit
that referenced
this pull request
Feb 8, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
commented
Feb 17, 2016
Contributor
Blocked from backporting until other Doc commits land on v4.x-staging |
MylesBorins pushed a commit
that referenced
this pull request
Feb 22, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Feb 22, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Mar 2, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: #4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
1. The release team's names were not in the sorted order and 2. the old list of releasers' names were not in bold This patch fixes both of these issues PR-URL: nodejs#4876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Oct 16, 2022
This was referenced Oct 16, 2022
This was referenced Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes both of these issues
cc @nodejs/release