Skip to content

esm: add back globalPreload tests - #48779

Merged
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:globalPreload
Jul 17, 2023
Merged

esm: add back globalPreload tests#48779
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:globalPreload

Conversation

@aduh95

@aduh95aduh95 commented Jul 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This started as a revert of 938341a.

#44710 removed setImportMetaCallback, removing possibility for hooks authors to modify the import.meta object. It also removed all hooks execution when node entry point was not a file (e.g. REPL, --eval, etc.) which was not a problem except for globalPreload which is always supposed to run. I've added some tests to ensure globalPreload behaves correctly in this case.
I've also added back the test that was removed in #46402 because it's good test for globalPreload and ensures mocking works – which is a very important use case for hooks IMO.

Refs: #46402
Fixes: #48778
Fixes: #48516

@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jul 15, 2023
GeoffreyBooth
GeoffreyBooth approved these changes Jul 15, 2023
View reviewed changes
Comment threadlib/internal/modules/esm/hooks.js Outdated
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 15, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52769/

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 16, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52790/

JakobJingleheimer
JakobJingleheimer approved these changes Jul 16, 2023
View reviewed changes

@JakobJingleheimerJakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 awesome, thanks for tackling this!

Comment threadlib/internal/main/eval_string.js
Comment threadtest/es-module/test-esm-loader-hooks.mjs Outdated
@aduh95@JakobJingleheimer
Update test/es-module/test-esm-loader-hooks.mjs
851f888
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 16, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52796/

@github-actionsgithub-actionsBot mentioned this pull request Jul 17, 2023
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52805/

@aduh95
aduh95 merged commit 16b8c71 into nodejs:mainJul 17, 2023
@aduh95

aduh95 commented Jul 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Landed in 16b8c71

@aduh95
aduh95 deleted the globalPreload branch July 17, 2023 15:26
This was referenced Jul 18, 2023
Open
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2023
Open
16 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95@Ceres6
esm: add back globalPreload tests and fix failing ones
9d7d595
PR-URL: nodejs#48779Fixes: nodejs#48778Fixes: nodejs#48516
Refs: nodejs#46402
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95@Ceres6
esm: add back globalPreload tests and fix failing ones
113a703
PR-URL: nodejs#48779Fixes: nodejs#48778Fixes: nodejs#48516
Refs: nodejs#46402
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@aduh95@UlisesGascon
esm: add back globalPreload tests and fix failing ones
903bc73
PR-URL: nodejs#48779Fixes: nodejs#48778Fixes: nodejs#48516
Refs: nodejs#46402
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@aduh95@RafaelGSS
esm: add back globalPreload tests and fix failing ones
a559747
PR-URL: #48779Fixes: #48778Fixes: #48516
Refs: #46402
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@UlisesGasconUlisesGascon mentioned this pull request Aug 15, 2023
Merged
@aduh95aduh95 mentioned this pull request Sep 7, 2023
Open
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95@targos
esm: add back globalPreload tests and fix failing ones
002a084
PR-URL: nodejs#48779Fixes: nodejs#48778Fixes: nodejs#48516
Refs: nodejs#46402
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targostargos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95@targos
esm: add back globalPreload tests and fix failing ones
63aa5d7
PR-URL: #48779
Backport-PR-URL: #50669Fixes: #48778Fixes: #48516
Refs: #46402
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: add back globalPreload tests and fix failing ones
5915a0d
PR-URL: nodejs/node#48779
Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#48778Fixes: nodejs/node#48516
Refs: nodejs/node#46402
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: add back globalPreload tests and fix failing ones
29f9d1c
PR-URL: nodejs/node#48779
Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#48778Fixes: nodejs/node#48516
Refs: nodejs/node#46402
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Loader preload code never executes esm loaders: getBuiltin() does not work with node:test

5 participants

@aduh95@nodejs-github-bot@GeoffreyBooth@JakobJingleheimer@targos