Skip to content

test: relocate test files fixtures for better understanding - #48787

Merged
nodejs-github-bot merged 8 commits into
nodejs:mainfrom
rluvaton:reorder-test-files
Jul 26, 2023
Merged

test: relocate test files fixtures for better understanding#48787
nodejs-github-bot merged 8 commits into
nodejs:mainfrom
rluvaton:reorder-test-files

Conversation

@rluvaton

@rluvatonrluvaton commented Jul 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

move all files that the test runner used by directory to their own folder

example of such a problem:

@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 15, 2023
@rluvatonrluvaton changed the title test: reorder test files fixtures for better understandingtest: relocate test files fixtures for better understandingJul 16, 2023
@rluvaton

rluvaton commented Jul 16, 2023

Copy link
Copy Markdown
MemberAuthor

The failing macOS test is unrelated, it's about the inspector

@rluvaton

rluvaton commented Jul 17, 2023

Copy link
Copy Markdown
MemberAuthor

Cc @MoLow

@rluvatonrluvaton mentioned this pull request Jul 25, 2023
Merged
@rluvaton
rluvatonforce-pushed the reorder-test-files branch from 3f16464 to 8c3dd7eCompareJuly 25, 2023 22:26
@rluvaton

rluvaton commented Jul 25, 2023

Copy link
Copy Markdown
MemberAuthor

Cc @benjamingr@cjihrig

@MoLow

MoLow commented Jul 26, 2023

Copy link
Copy Markdown
Member

@rluvaton can you fix failing tests?

@rluvaton

rluvaton commented Jul 26, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Hey, because more than a week passed a single reviewer is enough no? (because it blocking other PR and this is just test fixture relocation)

@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52940/

@atlowChemiatlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 26, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2023
@nodejs-github-bot
nodejs-github-bot merged commit bcaf198 into nodejs:mainJul 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in bcaf198

@rluvaton

rluvaton commented Jul 26, 2023

Copy link
Copy Markdown
MemberAuthor

Thanks

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@rluvaton@Ceres6
test: reorder test files fixtures for better understanding
6474b68
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton@Ceres6
test: reorder test files fixtures for better understanding
945dabc
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton@Ceres6
test: reorder test files fixtures for better understanding
e5f6106
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGascon

UlisesGascon commented Aug 14, 2023

Copy link
Copy Markdown
Member

This PR didn't land cleanly on node 20. Could you please make a backport?

@rluvaton

rluvaton commented Aug 14, 2023

Copy link
Copy Markdown
MemberAuthor

Sure, can you tell me what was the problem?

@RafaelGSS

RafaelGSS commented Aug 14, 2023

Copy link
Copy Markdown
Member

Sure, can you tell me what was the problem?

If you cherry-pick bcaf198 on v20.x-staging you should see the conflicts. Basically, it touches on some parts of #47653 which is a semver-major and won't go to v20.x.

@rluvatonrluvaton mentioned this pull request Aug 14, 2023
Closed
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@rluvaton
test: reorder test files fixtures for better understanding
7c07077
PR-URL: nodejs#48787
Backport-PR-URL: nodejs#49174
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@rluvatonrluvaton mentioned this pull request Aug 18, 2023
Closed
@rluvaton

rluvaton commented Aug 18, 2023

Copy link
Copy Markdown
MemberAuthor

Backport PR:

rluvaton added a commit to rluvaton/node that referenced this pull request Sep 4, 2023
@rluvaton
test: reorder test files fixtures for better understanding
2e0df36
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@rluvaton@UlisesGascon
test: reorder test files fixtures for better understanding
25e967a
PR-URL: #48787
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGasconUlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@rluvaton@targos
test: reorder test files fixtures for better understanding
0fea550
PR-URL: #48787
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: reorder test files fixtures for better understanding
9207a54
PR-URL: nodejs/node#48787
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: reorder test files fixtures for better understanding
28711e8
PR-URL: nodejs/node#48787
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLowMoLowMoLow approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rluvaton@nodejs-github-bot@MoLow@UlisesGascon@RafaelGSS@atlowChemi@targos