Uh oh!
There was an error while loading. Please reload this page.
deps: skip v8's regress/regress-1320641 on ppc64 and s390x - #48814
Closed
joyeecheung wants to merge 1 commit into
Closed
deps: skip v8's regress/regress-1320641 on ppc64 and s390x#48814joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
This breaks Node.js's V8 CI. We could turn them back on when it gets fixed on those platforms.
nodejs-github-bot
commented
Jul 17, 2023
Collaborator
Review requested:
|
richardlau
approved these changes
Jul 17, 2023
richardlau
commented
Jul 17, 2023
Member
FWIW the failure on our CI looks like 10:38:08 === mjsunit/regress/regress-1320641 ===10:38:08 --- stdout ---10:38:08 /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8: RangeError: Array buffer allocation failed10:38:08 const xs = new Uint16Array(3775336418);10:38:08 ^10:38:08 RangeError: Array buffer allocation failed10:38:08 at new ArrayBuffer (<anonymous>)10:38:08 at new Uint16Array (<anonymous>)10:38:08 at foo (/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8:14)10:38:08 at /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:12:110:38:08 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js --random-seed=96903975 --nohard-abort --testing-d8-test-runner --allow-natives-syntax10:38:08 10:38:08 ===10:38:08 === 1 tests failed10:38:08 === |
joyeecheung
commented
Jul 17, 2023
MemberAuthor
Maybe this is a better fix https://chromium-review.googlesource.com/c/v8/v8/+/4689686 |
Contributor
Not specific to ppc/s390. You can limit your virtual memory to 8 Gb with |
aymen94
approved these changes
Jul 18, 2023
joyeecheung
commented
Jul 18, 2023
MemberAuthor
Superseded by #48830 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks Node.js's V8 CI. We could turn them back on when it gets fixed on those platforms.
cc @nodejs/platform-s390 @nodejs/platform-ppc