Skip to content

doc: improve requireHostHeader - #48860

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
GuidoPenta:main
Jul 25, 2023
Merged

doc: improve requireHostHeader#48860
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
GuidoPenta:main

Conversation

@GuidoPenta

@GuidoPentaGuidoPenta commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

improved requireHostHeader documentation (daje)

@nodejs-github-bot

nodejs-github-bot commented Jul 20, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jul 20, 2023
mcollina
mcollina approved these changes Jul 21, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52882/

lpinca
lpinca approved these changes Jul 21, 2023
View reviewed changes
Comment threaddoc/api/http.md
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52888/

This was referenced Jul 22, 2023
Open
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Jul 25, 2023
Open
14 tasks
@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 36c72c8 into nodejs:mainJul 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 36c72c8

This was referenced Jul 26, 2023
Open
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@GuidoPenta@Ceres6
doc: improve requireHostHeader
467c69f
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jul 28, 2023
Open
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@GuidoPenta@Ceres6
doc: improve requireHostHeader
c1cd6ab
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@GuidoPenta@Ceres6
doc: improve requireHostHeader
4097dd3
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@GuidoPenta@UlisesGascon
doc: improve requireHostHeader
6ab2912
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@GuidoPenta@RafaelGSS
doc: improve requireHostHeader
eb7fa4b
PR-URL: #48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@GuidoPenta@RafaelGSS
doc: improve requireHostHeader
5e47308
PR-URL: #48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
@mcollinamcollinamcollina approved these changes
@ShogunPandaShogunPandaShogunPanda approved these changes
+1 more reviewer
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GuidoPenta@nodejs-github-bot@mcollina@ShogunPanda@lpinca@aymen94@marco-ippolito