Skip to content

doc: change duration to duration_ms on test documentation - #48892

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
arxngr:doc-rename-duration-to-duration_ns
Jul 25, 2023
Merged

doc: change duration to duration_ms on test documentation#48892
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
arxngr:doc-rename-duration-to-duration_ns

Conversation

@arxngr

@arxngrarxngr commented Jul 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

change duration to duration_ms in test documentation

Fixes: #48887

@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jul 23, 2023
@arxngrarxngr changed the title doc:change duration to duration_ns on test documentationdoc:change duration to duration_ms on test documentationJul 23, 2023
aduh95
aduh95 approved these changes Jul 23, 2023
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR. There's a typo in the commit message (duration_ns -> duration_ms), and there needs to be a space after the subsystem (doc:change -> doc: change). Could you amend the commit message and force push to your branch please? I can do it for you if you prefer.

@arxngrarxngr changed the title doc:change duration to duration_ms on test documentationdoc: change duration to duration_ms on test documentationJul 23, 2023
@arxngr

arxngr commented Jul 23, 2023

Copy link
Copy Markdown
ContributorAuthor

LGTM, thanks for the PR. There's a typo in the commit message (duration_ns -> duration_ms), and there needs to be a space after the subsystem (doc:change -> doc: change). Could you amend the commit message and force push to your branch please? I can do it for you if you prefer.

sure :)

@arxngr
arxngrforce-pushed the doc-rename-duration-to-duration_ns branch from 3afbda0 to c8faff2CompareJuly 23, 2023 13:36
@koshic

koshic commented Jul 23, 2023

Copy link
Copy Markdown

@0xArdi-N plz don't forget about test:fail

@arxngr

arxngr commented Jul 23, 2023

Copy link
Copy Markdown
ContributorAuthor

@0xArdi-N plz don't forget about test:fail

on it

@arxngr
arxngrforce-pushed the doc-rename-duration-to-duration_ns branch from c8faff2 to a20a7c8CompareJuly 23, 2023 13:41
@deokjinkim

deokjinkim commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

@0xArdi-N Thank you for contribution. Typo in commit title(duration_ns -> duration_ms) is not fixed yet. Could you please resolve this?

@arxngr
arxngrforce-pushed the doc-rename-duration-to-duration_ns branch from a20a7c8 to 9eca9daCompareJuly 23, 2023 14:24
@arxngr

arxngr commented Jul 23, 2023

Copy link
Copy Markdown
ContributorAuthor

@0xArdi-N Thank you for contribution. Typo in commit title(duration_ns -> duration_ms) is not fixed yet. Could you please resolve this?

hi @deokjinkim , I'm already fixed that. :)

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2023
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 71165e1 into nodejs:mainJul 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 71165e1

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@arxngr@Ceres6
doc: change duration to duration_ms on test documentation
aa61915
PR-URL: nodejs#48892Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@arxngr@Ceres6
doc: change duration to duration_ms on test documentation
7f78f2c
PR-URL: nodejs#48892Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@arxngr@Ceres6
doc: change duration to duration_ms on test documentation
711ccd0
PR-URL: nodejs#48892Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@arxngr@UlisesGascon
doc: change duration to duration_ms on test documentation
bc751ed
PR-URL: nodejs#48892Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@arxngr@RafaelGSS
doc: change duration to duration_ms on test documentation
d130e6f
PR-URL: #48892Fixes: #48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGasconUlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@arxngr@RafaelGSS
doc: change duration to duration_ms on test documentation
092f9fe
PR-URL: #48892Fixes: #48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos pushed a commit that referenced this pull request Oct 28, 2023
@arxngr@targos
doc: change duration to duration_ms on test documentation
e8a32fb
PR-URL: #48892Fixes: #48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: change duration to duration_ms on test documentation
64267bc
PR-URL: nodejs/node#48892Fixes: nodejs/node#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: change duration to duration_ms on test documentation
21be215
PR-URL: nodejs/node#48892Fixes: nodejs/node#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@MoLowMoLowMoLow approved these changes
@aduh95aduh95aduh95 approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
+1 more reviewer
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_runner: incorrect test:pass & test:fail events description, 'duration' instead of 'duration_ms'

10 participants

@arxngr@nodejs-github-bot@koshic@deokjinkim@lpinca@cjihrig@MoLow@aymen94@aduh95@atlowChemi