Skip to content

src,permission: restrict by default when pm enabled - #48907

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:fix/restrict-by-default-pm-enabled
Jul 26, 2023
Merged

src,permission: restrict by default when pm enabled#48907
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:fix/restrict-by-default-pm-enabled

Conversation

@RafaelGSS

@RafaelGSSRafaelGSS commented Jul 24, 2023

Copy link
Copy Markdown
Member

It goes according to the documentation:

When starting Node.js with --experimental-permission, the ability to access the file system through the fs module, spawn processes, use node:worker_threads and enable the runtime inspector will be restricted.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 24, 2023
@RafaelGSS
RafaelGSSforce-pushed the fix/restrict-by-default-pm-enabled branch from f1068f9 to cf6a089CompareJuly 24, 2023 18:43
@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52922/

lpinca
lpinca reviewed Jul 24, 2023
View reviewed changes
Comment threadtest/parallel/test-permission-inspector.js Outdated
@RafaelGSS
RafaelGSSforce-pushed the fix/restrict-by-default-pm-enabled branch from cf6a089 to 4ff3b90CompareJuly 24, 2023 20:43
@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52923/

@github-actionsgithub-actionsBot mentioned this pull request Jul 25, 2023
Open
14 tasks
@nodejs-github-bot

nodejs-github-bot commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52924/

@nodejs-github-bot

nodejs-github-bot commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52926/

@RafaelGSSRafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2023
@github-actionsgithub-actionsBot mentioned this pull request Jul 26, 2023
Open
14 tasks
@RafaelGSSRafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 26, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 14e7bd8 into nodejs:mainJul 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 14e7bd8

@github-actionsgithub-actionsBot mentioned this pull request Jul 27, 2023
Open
18 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@RafaelGSS@Ceres6
src,permission: restrict by default when pm enabled
06fbbb8
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2023
Open
19 tasks
@github-actionsgithub-actionsBot mentioned this pull request Jul 31, 2023
Open
18 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS@Ceres6
src,permission: restrict by default when pm enabled
d33d4a6
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS@Ceres6
src,permission: restrict by default when pm enabled
0ccb1d0
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@RafaelGSS@UlisesGascon
src,permission: restrict by default when pm enabled
6c05dd8
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS added a commit that referenced this pull request Aug 15, 2023
@RafaelGSS
src,permission: restrict by default when pm enabled
833e571
PR-URL: #48907
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS added a commit that referenced this pull request Aug 17, 2023
@RafaelGSS
src,permission: restrict by default when pm enabled
62a46d9
PR-URL: #48907
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@ShogunPandaShogunPandaShogunPanda approved these changes
@targostargostargos approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RafaelGSS@nodejs-github-bot@ShogunPanda@lpinca@targos@marco-ippolito