test: add `tmpdir.fileURL()` by LiviaMedeiros · Pull Request #49040 · nodejs/node

LiviaMedeiros · 2023-08-06T08:22:40Z

Almost every time tmpdir.path is used in tests, we have to import path to use it.
Whenever we need URL of something in tmpdir, we also have to import url.pathToFileURL.
Adding tmpdir.url would reduce

import{join}from'node:path';import{pathToFileURL}from'node:url';consttestFile=pathToFileURL(join(tmpdir.path,'subdir','tst-file-123'));

to

consttestFile=tmpdir.resolve('subdir','tst-file-123');

or to native resolving

consttmpBase=tmpdir.fileURL();consttestFile=newURL('subdir/tst-file-123',tmpBase);

Additionally, maybe we could add path-oriented tmpdir.resolve(...paths) to replace path.join(tmpdir.path, ...paths) in tests?

tniessen · 2023-08-06T14:23:16Z

Why is the URL not a URL?

LiviaMedeiros · 2023-08-06T15:43:37Z

Why is the URL not a URL?

For consistency with import.meta.url and general guideline. No strong opinion here.

tniessen · 2023-08-06T16:30:49Z

I see. For anyone else wondering the same thing, it sounds like the main issue is that URL is meant to be mutable, which is undesirable for values that are not meant to be modified.

aduh95 · 2023-08-08T12:59:26Z

We could have tmpdir.fileURL() which would return a new URL instance, and would accept a relative URL as optional parameter, that would be consistent with fixtures.mjs. wdyt?

joyeecheung · 2023-08-08T19:07:36Z

Considering we also already have fixtures.fileURL() and fixtures.path() I think tmpdir.fileURL() and tmpdir.resolve() (because tmpdir.path is already taken) would make a lot of sense (I've always wondered why we don't have tmpdir.resolve() whenever I have to do path.join(tmpdir.path))

nodejs-github-bot · 2023-08-10T17:17:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53136/

nodejs-github-bot · 2023-08-10T23:07:31Z

Landed in 7bbcb29

PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #49040 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs/node#49040 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: nodejs/node#49138 Refs: nodejs/node#49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs/node#49040 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: nodejs/node#49138 Refs: nodejs/node#49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 6, 2023

LiviaMedeiros changed the title ~~test: add tmpdir.url~~test: add tmpdir.fileURL()Aug 9, 2023

test: add tmpdir.fileURL()
0e08b72

LiviaMedeiros force-pushed the test-ft-tmpdir-url branch from 1dbf437 to 0e08b72Compare August 9, 2023 05:41

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2023

aduh95 approved these changes Aug 9, 2023
View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2023

joyeecheung approved these changes Aug 9, 2023
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023

This comment was marked as outdated.
Sign in to view

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023

nodejs-github-bot merged commit 7bbcb29 into nodejs:mainAug 10, 2023

github-actionsBot mentioned this pull request Aug 11, 2023
CI Reliability 2023-08-11 nodejs/reliability#634
Open
29 tasks

LiviaMedeiros mentioned this pull request Aug 13, 2023
test,benchmark: use tmpdir.fileURL()#49138
Merged

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: add tmpdir.fileURL()
a717c88
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: add tmpdir.fileURL()
f9cb59d
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
test: add tmpdir.fileURL()
946de9c
PR-URL: #49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
test: add tmpdir.fileURL()
59767f3
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
test: add tmpdir.fileURL()
669ac03
PR-URL: #49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request Aug 21, 2023
test,benchmark: use tmpdir.fileURL()
eeddbfa
PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
test,benchmark: use tmpdir.fileURL()
fac56db
PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
test: add tmpdir.fileURL()
abedad7
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos mentioned this pull request Nov 11, 2023
[v18.x] Backport most ESM and customization hook changes #50669
Closed

targos added the backported-to-v18.x label Nov 23, 2023

targos pushed a commit that referenced this pull request Nov 23, 2023
test: add tmpdir.fileURL()
65058d9
PR-URL: #49040 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos pushed a commit that referenced this pull request Nov 27, 2023
test,benchmark: use tmpdir.fileURL()
b011a49
PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: add tmpdir.fileURL()
1d47b07
PR-URL: nodejs/node#49040 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test,benchmark: use tmpdir.fileURL()
bdcdb85
PR-URL: nodejs/node#49138 Refs: nodejs/node#49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test: add tmpdir.fileURL()
82316a5
PR-URL: nodejs/node#49040 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test,benchmark: use tmpdir.fileURL()
1eea878
PR-URL: nodejs/node#49138 Refs: nodejs/node#49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Navigation Menu

Uh oh!

Uh oh!

test: add `tmpdir.fileURL()` - #49040

test: add `tmpdir.fileURL()`#49040
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-ft-tmpdir-url

LiviaMedeiros commented Aug 6, 2023•
edited
Loading

Uh oh!

tniessen commented Aug 6, 2023

Uh oh!

LiviaMedeiros commented Aug 6, 2023

Uh oh!

tniessen commented Aug 6, 2023

Uh oh!

aduh95 commented Aug 8, 2023

Uh oh!

joyeecheung commented Aug 8, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 10, 2023

Uh oh!

nodejs-github-bot commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

LiviaMedeiros commented Aug 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tniessen commented Aug 6, 2023

Uh oh!

LiviaMedeiros commented Aug 6, 2023

Uh oh!

tniessen commented Aug 6, 2023

Uh oh!

aduh95 commented Aug 8, 2023

Uh oh!

joyeecheung commented Aug 8, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 10, 2023

Uh oh!

nodejs-github-bot commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LiviaMedeiros commented Aug 6, 2023•
edited
Loading