Skip to content

gyp: put cctest filenames in variables - #49178

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zcbenz:patch-10
Sep 8, 2023
Merged

gyp: put cctest filenames in variables#49178
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zcbenz:patch-10

Conversation

@zcbenz

@zcbenzzcbenz commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

This is a followup to #46965, which will be very helpful for #47637.

@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Aug 15, 2023
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53344/

@github-actionsgithub-actionsBot mentioned this pull request Aug 18, 2023
Open
32 tasks
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53475/

@github-actionsgithub-actionsBot mentioned this pull request Aug 22, 2023
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53491/

This was referenced Aug 23, 2023
Open
Open
Open
Open
Open
@zcbenzzcbenz mentioned this pull request Sep 8, 2023
Merged
Qard
Qard approved these changes Sep 8, 2023
View reviewed changes
@QardQard added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 8, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 8, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3163f8d into nodejs:mainSep 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3163f8d

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@zcbenz@ruyadorno
gyp: put cctest filenames in variables
0f020ed
PR-URL: #49178
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This was referenced Sep 28, 2023
Closed
Merged
@zcbenzzcbenz mentioned this pull request Nov 28, 2023
Closed
27 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes
@anonriganonriganonrig approved these changes
@targostargostargos approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zcbenz@nodejs-github-bot@Qard@anonrig@targos@gengjiawen@joyeecheung@richardlau