[v20.x backport] cppgc related changes by joyeecheung · Pull Request #49187 · nodejs/node

joyeecheung · 2023-08-15T19:41:42Z

deps: V8: cherry-pick 93275031284c

Original commit message:

[cppgc] expose wrapper descriptor on CppHeap
This makes it possible for embedders to:
1. Avoid creating wrapper objects that happen to have a layout that
leads V8 to consider the object cppgc-managed while it's not.
Refs: https://github.com/nodejs/node/pull/43521
2. Create cppgc-managed wrapper objects when they do not own the
CppHeap. Refs: https://github.com/nodejs/node/pull/45704
Bug: v8:13960
Change-Id: If31f4d56c5ead59dc0d56f937494d23d631f7438
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4598833
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#88490}

Refs: v8/v8@9327503
PR-URL: #48660
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Jiawen Geng technicalcute@gmail.com

src: use effective cppgc wrapper id to deduce non-cppgc id

Previously we hard-code a wrapper id to be used in BaseObjects
to avoid accidentally triggering cppgc on these non-cppgc-managed
objects, but hard-coding can be be hacky and result in mismatch
when we start to create CppHeap ourselves. This patch makes it
more robust by deducing non-cppgc id from the effective cppgc id,
if there is one.

PR-URL: #48660
Refs: v8/v8@9327503
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Jiawen Geng technicalcute@gmail.com

src,tools: initialize cppgc

This patch:

Initializes cppgc in InitializeOncePerProcess() when
kNoInitializeCppgc is not set
Create a CppHeap and attach it to the Isolate when
there isn't one already during IsolateData initialization.
The CppHeap is detached and terminated when IsolateData
is freed.
Publishes the cppgc headers in the tarball.

This allows C++ addons to start using cppgc to manage objects.

A helper node::SetCppgcReference() is also added to help addons
enable cppgc tracing in a user-defined object.

Co-authored-by: Joyee Cheung joyeec9h3@gmail.com
Refs: #40786
PR-URL: #45704
Refs: https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit
Reviewed-By: Stephen Belanger admin@stephenbelanger.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

joyeecheung · 2023-08-15T19:42:44Z

oops, wrong base branch, it looks like github is not smart enough to pick it up after changing the base..opening a new one

joyeecheung · 2023-08-15T19:47:01Z

Oh, looks like it was because v20.x-staging was force-pushed. Rebasing it made it work again

nodejs-github-bot · 2023-08-15T20:00:09Z

Review requested:

@nodejs/gyp
@nodejs/startup
@nodejs/v8-update

Original commit message: [cppgc] expose wrapper descriptor on CppHeap This makes it possible for embedders to: 1. Avoid creating wrapper objects that happen to have a layout that leads V8 to consider the object cppgc-managed while it's not. Refs: nodejs#43521 2. Create cppgc-managed wrapper objects when they do not own the CppHeap. Refs: nodejs#45704 Bug: v8:13960 Change-Id: If31f4d56c5ead59dc0d56f937494d23d631f7438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4598833 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#88490} Refs: v8/v8@9327503 PR-URL: nodejs#48660 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

Previously we hard-code a wrapper id to be used in BaseObjects to avoid accidentally triggering cppgc on these non-cppgc-managed objects, but hard-coding can be be hacky and result in mismatch when we start to create CppHeap ourselves. This patch makes it more robust by deducing non-cppgc id from the effective cppgc id, if there is one. PR-URL: nodejs#48660 Refs: v8/v8@9327503 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

This patch: - Initializes cppgc in InitializeOncePerProcess() when kNoInitializeCppgc is not set - Create a CppHeap and attach it to the Isolate when there isn't one already during IsolateData initialization. The CppHeap is detached and terminated when IsolateData is freed. - Publishes the cppgc headers in the tarball. This allows C++ addons to start using cppgc to manage objects. A helper node::SetCppgcReference() is also added to help addons enable cppgc tracing in a user-defined object. Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> Refs: nodejs#40786 PR-URL: nodejs#45704 Refs: https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

nodejs-github-bot · 2023-08-18T00:35:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53417/

Original commit message: [cppgc] expose wrapper descriptor on CppHeap This makes it possible for embedders to: 1. Avoid creating wrapper objects that happen to have a layout that leads V8 to consider the object cppgc-managed while it's not. Refs: #43521 2. Create cppgc-managed wrapper objects when they do not own the CppHeap. Refs: #45704 Bug: v8:13960 Change-Id: If31f4d56c5ead59dc0d56f937494d23d631f7438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4598833 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#88490} Refs: v8/v8@9327503 PR-URL: #48660 Backport-PR-URL: #49187 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Refs: #40786 Refs: https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit

Previously we hard-code a wrapper id to be used in BaseObjects to avoid accidentally triggering cppgc on these non-cppgc-managed objects, but hard-coding can be be hacky and result in mismatch when we start to create CppHeap ourselves. This patch makes it more robust by deducing non-cppgc id from the effective cppgc id, if there is one. PR-URL: #48660 Backport-PR-URL: #49187 Refs: v8/v8@9327503 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Refs: #40786 Refs: https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit

This patch: - Initializes cppgc in InitializeOncePerProcess() when kNoInitializeCppgc is not set - Create a CppHeap and attach it to the Isolate when there isn't one already during IsolateData initialization. The CppHeap is detached and terminated when IsolateData is freed. - Publishes the cppgc headers in the tarball. This allows C++ addons to start using cppgc to manage objects. A helper node::SetCppgcReference() is also added to help addons enable cppgc tracing in a user-defined object. Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> Refs: #40786 PR-URL: #45704 Backport-PR-URL: #49187 Refs: https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #48660 Refs: v8/v8@9327503

UlisesGascon · 2023-08-18T11:41:20Z

Landed in 00fc8bb...099159c

Original commit message: [cppgc] expose wrapper descriptor on CppHeap This makes it possible for embedders to: 1. Avoid creating wrapper objects that happen to have a layout that leads V8 to consider the object cppgc-managed while it's not. Refs: nodejs#43521 2. Create cppgc-managed wrapper objects when they do not own the CppHeap. Refs: nodejs#45704 Bug: v8:13960 Change-Id: If31f4d56c5ead59dc0d56f937494d23d631f7438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4598833 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#88490} Refs: v8/v8@9327503 PR-URL: nodejs#48660 Backport-PR-URL: nodejs#49187 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Refs: nodejs#40786 Refs: https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit

joyeecheung changed the base branch from main to v20.x-stagingAugust 15, 2023 19:41

joyeecheung closed this Aug 15, 2023

joyeecheung reopened this Aug 15, 2023

joyeecheung force-pushed the cppgc-v20 branch from 93a54d4 to 8aa42e1Compare August 15, 2023 19:45

RafaelGSS force-pushed the v20.x-staging branch 2 times, most recently from 2a9aa46 to 21949c4Compare August 17, 2023 11:48

joyeecheungand others added 3 commits August 17, 2023 19:02

joyeecheung force-pushed the cppgc-v20 branch from 8aa42e1 to 6ce0b88Compare August 17, 2023 17:03

joyeecheung mentioned this pull request Aug 17, 2023
v20.6.0 proposal #49185
Merged

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2023

This comment was marked as outdated.
Sign in to view

github-actionsBot mentioned this pull request Aug 18, 2023
CI Reliability 2023-08-18 nodejs/reliability#640
Open
32 tasks

UlisesGascon approved these changes Aug 18, 2023
View reviewed changes

UlisesGascon closed this Aug 18, 2023

This was referenced Aug 21, 2023
CI Reliability 2023-08-21 nodejs/reliability#641
Open
CI Reliability 2023-08-22 nodejs/reliability#642
Open
CI Reliability 2023-08-23 nodejs/reliability#643
Open

codebytere mentioned this pull request Nov 28, 2023
Enable cppgc in Node.js on 32-bit platforms electron/electron#40626
Open

Navigation Menu

Uh oh!

Uh oh!

[v20.x backport] cppgc related changes - #49187

[v20.x backport] cppgc related changes#49187
joyeecheung wants to merge 3 commits into
nodejs:v20.x-stagingfrom
joyeecheung:cppgc-v20

joyeecheung commented Aug 15, 2023

Uh oh!

joyeecheung commented Aug 15, 2023

Uh oh!

joyeecheung commented Aug 15, 2023

Uh oh!

nodejs-github-bot commented Aug 15, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 18, 2023

Uh oh!

UlisesGascon commented Aug 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

joyeecheung commented Aug 15, 2023

deps: V8: cherry-pick 93275031284c

src: use effective cppgc wrapper id to deduce non-cppgc id

src,tools: initialize cppgc

Uh oh!

joyeecheung commented Aug 15, 2023

Uh oh!

joyeecheung commented Aug 15, 2023

Uh oh!

nodejs-github-bot commented Aug 15, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 18, 2023

Uh oh!

UlisesGascon commented Aug 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants