Skip to content

doc: caveat unavailability of import.meta.resolve in custom loaders - #49242

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
JakobJingleheimer:doc/add-loader-caveat-to-import-meta-resolve-
Aug 19, 2023
Merged

doc: caveat unavailability of import.meta.resolve in custom loaders#49242
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
JakobJingleheimer:doc/add-loader-caveat-to-import-meta-resolve-

Conversation

@JakobJingleheimer

@JakobJingleheimerJakobJingleheimer commented Aug 19, 2023

Copy link
Copy Markdown
Member

closes#49198

@JakobJingleheimerJakobJingleheimer self-assigned this Aug 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Aug 19, 2023
@JakobJingleheimer
JakobJingleheimer marked this pull request as ready for review August 19, 2023 12:20
@JakobJingleheimerJakobJingleheimer added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 19, 2023
@github-actions

github-actionsBot commented Aug 19, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve.

@aduh95

aduh95 commented Aug 19, 2023

Copy link
Copy Markdown
Contributor

Can you fix the linter error please?

@JakobJingleheimer

JakobJingleheimer commented Aug 19, 2023

Copy link
Copy Markdown
MemberAuthor

Gah, friggin line-wrap. It's fixed

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 19, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 41a3a1d into nodejs:mainAug 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in 41a3a1d

@JakobJingleheimer
JakobJingleheimer deleted the doc/add-loader-caveat-to-import-meta-resolve- branch August 20, 2023 12:52
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@JakobJingleheimer@UlisesGascon
doc: caveat unavailability of import.meta.resolve in custom loaders
5a363bb
PR-URL: #49242
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@UlisesGasconUlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@JakobJingleheimer@targos
doc: caveat unavailability of import.meta.resolve in custom loaders
222a378
PR-URL: nodejs#49242
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targostargos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@JakobJingleheimer@targos
doc: caveat unavailability of import.meta.resolve in custom loaders
58eaf3f
PR-URL: #49242
Backport-PR-URL: #50669
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: caveat unavailability of import.meta.resolve in custom
1bc1ddd
PR-URL: nodejs/node#49242
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: caveat unavailability of import.meta.resolve in custom
1df7903
PR-URL: nodejs/node#49242
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

@JakobJingleheimerJakobJingleheimer

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

import.meta.resolve no longer available in loaders >= v20

5 participants

@JakobJingleheimer@nodejs-github-bot@aduh95@GeoffreyBooth@targos