Skip to content

doc: edit import.meta.resolve documentation - #49247

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:import-meta-resolve
Sep 5, 2023
Merged

doc: edit import.meta.resolve documentation#49247
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:import-meta-resolve

Conversation

@aduh95

@aduh95aduh95 commented Aug 19, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • add missing history entry.
  • fix the return value description:
    • The return value doesn't have to be a file: URL, it can be of any scheme.
    • The return value doesn't have to correspond to a module, it can be a directory or something that doesn't exist.
  • merge the two code examples, remove the use of the non-standard second argument.
  • merge the two caveats.
  • do not mention the old implementation, the history section is already there for that.

Refs: #49028

@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Aug 19, 2023
JakobJingleheimer
JakobJingleheimer reviewed Aug 19, 2023
View reviewed changes
Comment threaddoc/api/esm.md Outdated
Comment threaddoc/api/esm.md Outdated
GeoffreyBooth
GeoffreyBooth approved these changes Aug 19, 2023
View reviewed changes
Comment threaddoc/api/esm.md Outdated
Comment threaddoc/api/esm.md Outdated
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 19, 2023
@GeoffreyBoothGeoffreyBooth added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 19, 2023
@github-actions

github-actionsBot commented Aug 19, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

@GeoffreyBooth

GeoffreyBooth commented Aug 19, 2023•
edited by aduh95
Loading

Copy link
Copy Markdown
Member

Adding fast-trackPRs that do not need to wait for 48 hours to land. in case it’s possible to add this to Monday’s release.

@GeoffreyBoothGeoffreyBooth mentioned this pull request Aug 19, 2023
Merged
@joyeecheung

joyeecheung commented Aug 27, 2023

Copy link
Copy Markdown
Member

This needs a rebase

@aduh95aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Sep 4, 2023
@GeoffreyBoothGeoffreyBooth added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e11c7b7 into nodejs:mainSep 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in e11c7b7

@aduh95
aduh95 deleted the import-meta-resolve branch September 5, 2023 08:06
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95@ruyadorno
doc: edit import.meta.resolve documentation
b9d4a80
PR-URL: #49247
Refs: #49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95@targos
doc: edit import.meta.resolve documentation
16580a4
PR-URL: nodejs#49247
Refs: nodejs#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@targostargos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95@targos
doc: edit import.meta.resolve documentation
c20fdb4
PR-URL: #49247
Backport-PR-URL: #50669
Refs: #49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: edit import.meta.resolve documentation
11700d7
PR-URL: nodejs/node#49247
Backport-PR-URL: nodejs/node#50669
Refs: nodejs/node#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: edit import.meta.resolve documentation
054b934
PR-URL: nodejs/node#49247
Backport-PR-URL: nodejs/node#50669
Refs: nodejs/node#49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakobJingleheimerJakobJingleheimerJakobJingleheimer left review comments
@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@guybedfordguybedfordguybedford approved these changes
+1 more reviewer
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95@nodejs-github-bot@GeoffreyBooth@joyeecheung@guybedford@JakobJingleheimer@aymen94@targos