Skip to content

stream: use Buffer.from when constructor is a Buffer - #49250

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
KhafraDev:streams-byob-deprecation-warning
Aug 26, 2023
Merged

stream: use Buffer.from when constructor is a Buffer #49250
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
KhafraDev:streams-byob-deprecation-warning

Conversation

@KhafraDev

@KhafraDevKhafraDev commented Aug 19, 2023

Copy link
Copy Markdown
Member

When using BYOB streams, it's possible for the constructor in
readableByteStreamControllerConvertPullIntoDescriptor to be a node
Buffer. If it is, use Buffer.from over new ctor.

Fixes#49245

@KhafraDev
stream: use Buffer.from when constructor is a Buffer
a45d249
When using BYOB streams, it's possible for the constructor in
readableByteStreamControllerConvertPullIntoDescriptor to be a node
Buffer. If it is, use `Buffer.from` over `new ctor`.
Fixesnodejs#49245
@KhafraDev
stream: use Buffer.from when constructor is a Buffer
1427d62
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Aug 19, 2023
debadree25
debadree25 reviewed Aug 20, 2023
View reviewed changes
Comment threadtest/parallel/test-whatwg-readablebytestreambyob.js
@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 20, 2023
LiviaMedeiros
LiviaMedeiros reviewed Aug 20, 2023
View reviewed changes
Comment threadtest/parallel/test-whatwg-readablebytestreambyob.js Outdated
@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 20, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53469/

@github-actionsgithub-actionsBot mentioned this pull request Aug 21, 2023
Open
35 tasks
This was referenced Aug 22, 2023
Open
Open
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53561/

@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 4ba7370 into nodejs:mainAug 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4ba7370

@KhafraDev
KhafraDev deleted the streams-byob-deprecation-warning branch August 26, 2023 13:48
@KhafraDev

KhafraDev commented Aug 26, 2023

Copy link
Copy Markdown
MemberAuthor

thank you @debadree25 for dealing with the CI ❤️

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@KhafraDev@UlisesGascon
stream: use Buffer.from when constructor is a Buffer
0eea7fd
When using BYOB streams, it's possible for the constructor in
readableByteStreamControllerConvertPullIntoDescriptor to be a node
Buffer. If it is, use `Buffer.from` over `new ctor`.
Fixes#49245
PR-URL: #49250
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@UlisesGasconUlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@KhafraDev@targos
stream: use Buffer.from when constructor is a Buffer
ee4fc7d
When using BYOB streams, it's possible for the constructor in
readableByteStreamControllerConvertPullIntoDescriptor to be a node
Buffer. If it is, use `Buffer.from` over `new ctor`.
Fixes#49245
PR-URL: #49250
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
stream: use Buffer.from when constructor is a Buffer
3ac97a2
When using BYOB streams, it's possible for the constructor in
readableByteStreamControllerConvertPullIntoDescriptor to be a node
Buffer. If it is, use `Buffer.from` over `new ctor`.
Fixesnodejs/node#49245
PR-URL: nodejs/node#49250
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
stream: use Buffer.from when constructor is a Buffer
090679c
When using BYOB streams, it's possible for the constructor in
readableByteStreamControllerConvertPullIntoDescriptor to be a node
Buffer. If it is, use `Buffer.from` over `new ctor`.
Fixesnodejs/node#49245
PR-URL: nodejs/node#49250
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes
+1 more reviewer
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DeprecatedWarning for Buffer when using the following API ReadableStreamBYOBReader in stream

5 participants

@KhafraDev@nodejs-github-bot@anonrig@debadree25@LiviaMedeiros