Skip to content

worker: protect against user mutating well-known prototypes - #49270

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:message-channel-frozen-prototype
Aug 23, 2023
Merged

worker: protect against user mutating well-known prototypes#49270
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:message-channel-frozen-prototype

Conversation

@aduh95

@aduh95aduh95 commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Fixes: #49259

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Aug 21, 2023
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53473/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit bca14f8 into nodejs:mainAug 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in bca14f8

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@aduh95@UlisesGascon
worker: protect against user mutating well-known prototypes
0179c6d
PR-URL: #49270Fixes: #49259
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@UlisesGasconUlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@aduh95@targos
worker: protect against user mutating well-known prototypes
879b958
PR-URL: #49270Fixes: #49259
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
worker: protect against user mutating well-known prototypes
40a0726
PR-URL: nodejs/node#49270Fixes: nodejs/node#49259
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
worker: protect against user mutating well-known prototypes
5685636
PR-URL: nodejs/node#49270Fixes: nodejs/node#49259
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
@KhafraDevKhafraDevKhafraDev approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Freezing EventTarget.prototype breaks MessageChannel

6 participants

@aduh95@nodejs-github-bot@bnoordhuis@benjamingr@anonrig@KhafraDev