test: make test-worker-prof more robust by joyeecheung · Pull Request #49274 · nodejs/node

joyeecheung · 2023-08-21T17:01:20Z

Use a JS workload instead of repeating FS operations to make it less flaky on machines with little resources.
Refs: #26401
Refs: nodejs/reliability#640

joyeecheung · 2023-08-22T12:21:43Z

Stress test on Windows 2022 + VS 2019 https://ci.nodejs.org/job/node-stress-single-test/418/

nodejs-github-bot · 2023-08-22T12:31:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53492/

joyeecheung · 2023-08-22T17:12:40Z

Looks like it can still be flaky with the current workload. Switching to a time-based workload...

nodejs-github-bot · 2023-08-22T17:19:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53498/

nodejs-github-bot · 2023-08-23T13:24:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53517/

joyeecheung · 2023-08-23T13:26:53Z

Another stress test on more platforms: https://ci.nodejs.org/job/node-stress-single-test/420/

joyeecheung · 2023-08-25T10:26:07Z

Updated the workload a bit, this seems to guarantee ~1000 ticks on both the parent and the worker.

nodejs-github-bot · 2023-08-25T10:29:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53554/

joyeecheung · 2023-08-25T10:55:08Z

Another stress test: https://ci.nodejs.org/job/node-stress-single-test/422/

nodejs-github-bot · 2023-08-27T21:45:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53581/

nodejs-github-bot · 2023-08-27T22:18:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53584/

Use a JS workload instead of repeating FS operations and use a timer to make it less flaky on machines with little resources.

joyeecheung · 2023-08-28T08:16:49Z

Looks like the CI is having trouble rebasing the PR. Manually rebased instead.

nodejs-github-bot · 2023-08-28T08:17:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53588/

nodejs-github-bot · 2023-08-30T22:04:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53655/

nodejs-github-bot · 2023-08-31T08:41:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53659/

nodejs-github-bot · 2023-09-01T19:44:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53679/

nodejs-github-bot · 2023-09-02T20:13:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53695/

nodejs-github-bot · 2023-09-04T21:54:01Z

Landed in 7f001c2

Use a JS workload instead of repeating FS operations and use a timer to make it less flaky on machines with little resources. PR-URL: #49274 Refs: #26401 Refs: nodejs/reliability#640 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

joyeecheung marked this pull request as ready for review August 21, 2023 17:01

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 21, 2023

joyeecheung force-pushed the worker-prof-test branch from 097acb3 to c5d821dCompare August 21, 2023 17:03

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2023

joyeecheung force-pushed the worker-prof-test branch from c5d821d to d966328Compare August 22, 2023 17:12

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2023

github-actionsBot mentioned this pull request Aug 23, 2023
CI Reliability 2023-08-23 nodejs/reliability#643
Open
27 tasks

This was referenced Aug 24, 2023
CI Reliability 2023-08-24 nodejs/reliability#644
Open
CI Reliability 2023-08-25 nodejs/reliability#645
Open

joyeecheung force-pushed the worker-prof-test branch from 7779fab to 5c66341Compare August 25, 2023 10:26

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2023

This was referenced Aug 26, 2023
CI Reliability 2023-08-26 nodejs/reliability#646
Open
CI Reliability 2023-08-27 nodejs/reliability#647
Open

github-actionsBot mentioned this pull request Aug 28, 2023
CI Reliability 2023-08-28 nodejs/reliability#648
Open
25 tasks

test: make test-worker-prof more robust
0d3a6f2
Use a JS workload instead of repeating FS operations and use a timer to make it less flaky on machines with little resources.

joyeecheung force-pushed the worker-prof-test branch from 5c66341 to 0d3a6f2Compare August 28, 2023 08:15

This was referenced Aug 29, 2023
CI Reliability 2023-08-29 nodejs/reliability#649
Open
CI Reliability 2023-08-30 nodejs/reliability#650
Open

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2023

github-actionsBot mentioned this pull request Aug 31, 2023
CI Reliability 2023-08-31 nodejs/reliability#651
Open
18 tasks

github-actionsBot mentioned this pull request Sep 1, 2023
CI Reliability 2023-09-01 nodejs/reliability#652
Open
20 tasks

github-actionsBot mentioned this pull request Sep 2, 2023
CI Reliability 2023-09-02 nodejs/reliability#653
Open
22 tasks

This was referenced Sep 3, 2023
CI Reliability 2023-09-03 nodejs/reliability#654
Open
CI Reliability 2023-09-04 nodejs/reliability#655
Open

benjamingr approved these changes Sep 4, 2023
View reviewed changes

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2023

nodejs-github-bot merged commit 7f001c2 into nodejs:mainSep 4, 2023

This was referenced Sep 5, 2023
CI Reliability 2023-09-05 nodejs/reliability#656
Open
CI Reliability 2023-09-06 nodejs/reliability#657
Open
CI Reliability 2023-09-07 nodejs/reliability#658
Open

This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged

Uh oh!

Uh oh!

Conversation

joyeecheung commented Aug 21, 2023

Uh oh!

joyeecheung commented Aug 22, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 22, 2023

Uh oh!

joyeecheung commented Aug 22, 2023

Uh oh!

nodejs-github-bot commented Aug 22, 2023

Uh oh!

nodejs-github-bot commented Aug 23, 2023

Uh oh!

joyeecheung commented Aug 23, 2023

Uh oh!

joyeecheung commented Aug 25, 2023

Uh oh!

nodejs-github-bot commented Aug 25, 2023

Uh oh!

joyeecheung commented Aug 25, 2023

Uh oh!

nodejs-github-bot commented Aug 27, 2023

Uh oh!

nodejs-github-bot commented Aug 27, 2023

Uh oh!

joyeecheung commented Aug 28, 2023

Uh oh!

nodejs-github-bot commented Aug 28, 2023

Uh oh!

nodejs-github-bot commented Aug 30, 2023

Uh oh!

nodejs-github-bot commented Aug 31, 2023

Uh oh!

nodejs-github-bot commented Sep 1, 2023

Uh oh!

nodejs-github-bot commented Sep 2, 2023

Uh oh!

nodejs-github-bot commented Sep 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joyeecheung commented Aug 22, 2023•
edited
Loading