Skip to content

doc: add riscv64 to list of architectures - #49284

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
sxa:riscv64doc
Aug 26, 2023
Merged

doc: add riscv64 to list of architectures#49284
aduh95 merged 1 commit into
nodejs:mainfrom
sxa:riscv64doc

Conversation

@sxa

@sxasxa commented Aug 22, 2023•
edited by aduh95
Loading

Copy link
Copy Markdown
Member

Simple doc change to add riscv64 to list of things that os.arch() and process.arch can return.

Fixes: #49278

@sxa
sxa requested a review from richardlauAugust 22, 2023 14:47
@sxasxa self-assigned this Aug 22, 2023
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 22, 2023
@richardlau

richardlau commented Aug 22, 2023

Copy link
Copy Markdown
Member

If anyone is wondering where to get such a riscv64 Node.js build, see https://unofficial-builds.nodejs.org/ (nodejs/unofficial-builds#54).

@richardlaurichardlau added the riscv64 Issues and PRs related to the riscv64 architecture. label Aug 22, 2023
@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 23, 2023
@sxa
doc: add riscv64 to list of architectures
d927a2b
PR-URL: nodejs#49284
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa

sxa commented Aug 24, 2023

Copy link
Copy Markdown
MemberAuthor

(Force push to correct the PR_URL as I'd cut & pasted the issue link instead of the PR)

@aduh95

aduh95 commented Aug 26, 2023

Copy link
Copy Markdown
Contributor

(Force push to correct the PR_URL as I'd cut & pasted the issue link instead of the PR)

Setting the PR URL yourself in the commit message is really not necessary, our automation does that along with adding the names of those who approved the change. It doesn't hurt to add it manually, but you run into the risk of doing a typo.

@aduh95
aduh95 merged commit 3d0a317 into nodejs:mainAug 26, 2023
@aduh95

aduh95 commented Aug 26, 2023

Copy link
Copy Markdown
Contributor

Landed in 3d0a317

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@sxa@UlisesGascon
doc: add riscv64 to list of architectures
f72e79e
PR-URL: #49284
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Fixes: #49278
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Sep 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
+2 more reviewers
@aymen94aymen94aymen94 approved these changes
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sxasxa

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.riscv64Issues and PRs related to the riscv64 architecture.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add riscv64 to the list of supported architectures

9 participants

@sxa@richardlau@aduh95@lpinca@tniessen@aymen94@VoltrexKeyva@targos@nodejs-github-bot