Skip to content

tools: remove v8_dump_build_config action - #49301

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zcbenz:patch-14
Aug 27, 2023
Merged

tools: remove v8_dump_build_config action#49301
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zcbenz:patch-14

Conversation

@zcbenz

@zcbenzzcbenz commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

The deps/v8/tools/testrunner/utils/dump_build_config_gyp.py script that this action relies on had been deleted in #44741, it is mysterious that gyp build does not report any error.

@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 24, 2023
@gengjiawengengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53536/

@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5522/

@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5522/

@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5522/

@joyeecheungjoyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 0409cdd into nodejs:mainAug 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0409cdd

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@zcbenz@UlisesGascon
tools: remove v8_dump_build_config action
9a8fb4f
The script has been removed in #44741.
PR-URL: #49301
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Sep 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zcbenz@nodejs-github-bot@lpinca@gengjiawen@richardlau@joyeecheung