Uh oh!
There was an error while loading. Please reload this page.
build: add --write-snapshot-as-array-literals to configure.py - #49312
Closed
joyeecheung wants to merge 1 commit into
Closed
build: add --write-snapshot-as-array-literals to configure.py#49312joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
This makes it easier to locate indeterminism in the snapshot, with the following command: $ ./configure --write-snapshot-as-array-literals $ make V= $ mv out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc $ make V= $ diff out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc
joyeecheung
marked this pull request as ready for review
August 24, 2023 16:37
nodejs-github-bot
commented
Aug 24, 2023
Collaborator
Review requested:
|
bnoordhuis
approved these changes
Aug 25, 2023
nodejs-github-bot
commented
Aug 31, 2023
Collaborator
20 tasks
nodejs-github-bot
commented
Sep 1, 2023
Collaborator
22 tasks
nodejs-github-bot
commented
Sep 2, 2023
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49312 ✔ Done loading data for nodejs/node/pull/49312 ----------------------------------- PR info ------------------------------------ Title build: add --write-snapshot-as-array-literals to configure.py (#49312) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:config-array-literals -> nodejs:main Labels lib / src, needs-ci Commits 1 - build: add --write-snapshot-as-array-literals to configure.py Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/49312 Refs: https://github.com/nodejs/build/issues/3043 Reviewed-By: Ben Noordhuis ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49312 Refs: https://github.com/nodejs/build/issues/3043 Reviewed-By: Ben Noordhuis -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 24 Aug 2023 16:37:26 GMT ✔ Approvals: 1 ✔ - Ben Noordhuis (@bnoordhuis) (TSC): https://github.com/nodejs/node/pull/49312#pullrequestreview-1595533008 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-09-01T19:44:30Z: https://ci.nodejs.org/job/node-test-pull-request/53681/ - Querying data for job/node-test-pull-request/53681/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6060350802 |
This was referenced Sep 3, 2023
joyeecheung
commented
Sep 4, 2023
MemberAuthor
Somehow the GitHub UI says "All checks have passed" and node-core-utils still complains about it...perhaps something is wrong the the GitHub API result, landing it manually. |
joyeecheung added a commit
that referenced
this pull request
Sep 4, 2023
This makes it easier to locate indeterminism in the snapshot, with the following command: $ ./configure --write-snapshot-as-array-literals $ make V= $ mv out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc $ make V= $ diff out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc PR-URL: #49312 Refs: nodejs/build#3043 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
joyeecheung
commented
Sep 4, 2023
MemberAuthor
Landed in 0028fd1 |
This was referenced Sep 5, 2023
ruyadorno pushed a commit
that referenced
this pull request
Sep 28, 2023
This makes it easier to locate indeterminism in the snapshot, with the following command: $ ./configure --write-snapshot-as-array-literals $ make V= $ mv out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc $ make V= $ diff out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc PR-URL: #49312 Refs: nodejs/build#3043 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to locate indeterminism in the snapshot, with the following command:
$ ./configure --write-snapshot-as-array-literals
$ make V=
$ mv out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc
$ make V=
$ diff out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc
Refs: nodejs/build#3043