test_runner: fix typescript coverage by MoLow · Pull Request #49406 · nodejs/node

MoLow · 2023-08-30T05:23:13Z

not sure how to test this, any help appreciated

nodejs-github-bot · 2023-08-30T05:23:18Z

Review requested:

@nodejs/test_runner

MoLow · 2023-08-30T05:24:50Z

@cjihrig do we have a way to reproduce an error in coverage collection? I want to snapshot this diagnostic that was missing

I think the easiest thing would be to monkey patch TestCoverage.prototype.summary() or TestCoverage.prototype.cleanup() so that an error is reported.

We can also create a dumb loader like ts-node that instead of reading typescript file it will read plain txt and execute them as JS

GeoffreyBooth · 2023-08-30T17:16:41Z

I think the easiest thing would be to monkey patch TestCoverage.prototype.summary() or TestCoverage.prototype.cleanup() so that an error is reported.

Not sure if this is relevant but in general we’re trying to avoid encouraging users to ever monkey-patch anything; that’s why the Loaders API / module customization hooks exist, and we plan to extend that model to other systems like FS and REPL. We’ve already added import { register } from 'node:module', the plan is to create import { register } from 'node:fs' and from node:repl and so on. Maybe you might want to create import { register } from 'node:test' to allow users to define customization hooks for various parts of the test runner flow?

cjihrig · 2023-08-30T17:23:39Z

we’re trying to avoid encouraging users to ever monkey-patch anything

Unless I misunderstood the original question, @MoLow is trying to trigger an error for the purposes of a Node unit test. This is not something end users should ever be doing.

GeoffreyBooth · 2023-08-30T18:10:11Z

This is not something end users should ever be doing.

Excellent, that’s why I wasn’t sure if my comment was relevant. Still though, if/when we need to provide customization abilities for the test runner, like a way to customize output or something, we should consider trying to provide APIs that are somewhat standardized across systems if possible. Maybe that won’t ever be necessary for the test runner since the reporters themselves are so customizable, but I just wanted to bring it up before people started designing new things.

MoLow · 2023-08-31T06:36:16Z

@cjihrig you understood me correctly

MoLow · 2023-09-04T10:17:09Z

@nodejs/test_runner I believe this is ready for reviews

nodejs-github-bot · 2023-09-04T13:12:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53720/

nodejs-github-bot · 2023-09-04T15:55:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53723/

nodejs-github-bot · 2023-09-04T17:56:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53726/

nodejs-github-bot · 2023-09-04T21:45:08Z

Landed in 47c5152

nicoabie · 2023-09-04T23:42:01Z

Thanks a lot guys!

PR-URL: #49406Fixes: #49398 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs/node#49406Fixes: nodejs/node#49398 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MoLow requested a review from cjihrig August 30, 2023 05:23

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 30, 2023

MoLow commented Aug 30, 2023
View reviewed changes

MoLow force-pushed the test-runner-typescript-coverage branch from 2a9c0ed to 53924b2Compare August 30, 2023 05:31

MoLow force-pushed the test-runner-typescript-coverage branch from 53924b2 to 3ed2c63Compare September 4, 2023 10:07

atlowChemi approved these changes Sep 4, 2023
View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023

cjihrig approved these changes Sep 4, 2023
View reviewed changes

Comment threadtest/fixtures/test-runner/output/coverage_failure.js Outdated

MoLow requested a review from atlowChemi September 4, 2023 15:50

MoLow force-pushed the test-runner-typescript-coverage branch from 3ed2c63 to 8564f65Compare September 4, 2023 15:50

MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 4, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023

atlowChemi approved these changes Sep 4, 2023
View reviewed changes

test_runner: fix typescript coverage
92edcf7

MoLow force-pushed the test-runner-typescript-coverage branch from 8564f65 to 92edcf7Compare September 4, 2023 16:37

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023

atlowChemi approved these changes Sep 4, 2023
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2023

nodejs-github-bot merged commit 47c5152 into nodejs:mainSep 4, 2023

This was referenced Sep 5, 2023
CI Reliability 2023-09-05 nodejs/reliability#656
Open
CI Reliability 2023-09-06 nodejs/reliability#657
Open
CI Reliability 2023-09-07 nodejs/reliability#658
Open
CI Reliability 2023-09-08 nodejs/reliability#659
Open

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
test_runner: fix typescript coverage
e7285d4
PR-URL: #49406Fixes: #49398 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged

targos pushed a commit that referenced this pull request Nov 27, 2023
test_runner: fix typescript coverage
429846f
PR-URL: #49406Fixes: #49398 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test_runner: fix typescript coverage
4327a7e
PR-URL: nodejs/node#49406Fixes: nodejs/node#49398 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
test_runner: fix typescript coverage
e0c4795
PR-URL: nodejs/node#49406Fixes: nodejs/node#49398 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MoLow deleted the test-runner-typescript-coverage branch May 24, 2024 09:01

Uh oh!

Uh oh!

Conversation

MoLow commented Aug 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 30, 2023

Uh oh!

MoLowAug 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjihrigAug 30, 2023

Choose a reason for hiding this comment

Uh oh!

rluvatonAug 30, 2023

Choose a reason for hiding this comment

Uh oh!

GeoffreyBooth commented Aug 30, 2023

Uh oh!

cjihrig commented Aug 30, 2023

Uh oh!

GeoffreyBooth commented Aug 30, 2023

Uh oh!

MoLow commented Aug 31, 2023

Uh oh!

MoLow commented Sep 4, 2023

Uh oh!

nodejs-github-bot commented Sep 4, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 4, 2023

Uh oh!

nodejs-github-bot commented Sep 4, 2023

Uh oh!

nodejs-github-bot commented Sep 4, 2023

Uh oh!

nicoabie commented Sep 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MoLow commented Aug 30, 2023•
edited
Loading

MoLowAug 30, 2023•
edited
Loading