deps: V8: backport 0aa622e12893 by joyeecheung · Pull Request #49419 · nodejs/node

joyeecheung · 2023-08-31T09:17:27Z

Original commit message:

[api] allow v8::Data as internal field
Previously only v8::Value can be stored as internal fields.
In some cases, however, it's necessary for the embedder to
tie the lifetime of a v8::Data with the lifetime of a
JS object, and that v8::Data may not be a v8::Value, as
it can be something returned from the V8 API. One way to
keep the v8::Data alive may be to use a v8::Persistent<v8::Data>
but that can easily lead to leaks.
This patch changes v8::Object::GetInternalField() and
v8::Object::SetInernalField() to accept v8::Data instead of just
v8::Value, so that v8::Data can kept alive by a JS object in
a way that the GC can be aware of to address this problem.
This is a breaking change for embedders
using v8::Object::GetInternalField() as it changes the return
type. Since most v8::Value subtypes only support direct casts
from v8::Value but not v8::Data, calls like
object->GetInternalField(index).As<v8::External>()
needs to be updated to cast the value to v8::Value first:
object->GetInternalField(index).As<v8::Value>().As<v8::External>()
Bug: v8:14120
Change-Id: I731c958d1756b9d5ee4a3e78813416cd60d1b7ca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4707972
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#89718}

Refs: v8/v8@0aa622e

nodejs-github-bot · 2023-08-31T09:17:31Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

joyeecheung · 2023-08-31T09:28:34Z

For v20.x this needs a manual non-ABI-breaking backport (probably by doing a workaround to add a similarly-named method with the signature, instead of just breaking it).

joyeecheung · 2023-08-31T09:39:40Z

Uh-oh, this was just reverted in the upstream. I'll investigate the crash that caused the revert. Marking it as blocked for now..

joyeecheung · 2023-08-31T20:36:37Z

Reland opened in the upstream: https://chromium-review.googlesource.com/c/v8/v8/+/4834471

Original commit message: Reland "[api] allow v8::Data as internal field" This is a reland of commit 0aa622e12893e9921c01a34ce9507b544e599c4a The original patch tried to run a test that calls exit() in the fatal error handler in parallel, which would not work. This marked the test with TEST() to avoid running it in parallel. Original change's description: > [api] allow v8::Data as internal field > > Previously only v8::Value can be stored as internal fields. > In some cases, however, it's necessary for the embedder to > tie the lifetime of a v8::Data with the lifetime of a > JS object, and that v8::Data may not be a v8::Value, as > it can be something returned from the V8 API. One way to > keep the v8::Data alive may be to use a v8::Persistent<v8::Data> > but that can easily lead to leaks. > > This patch changes v8::Object::GetInternalField() and > v8::Object::SetInernalField() to accept v8::Data instead of just > v8::Value, so that v8::Data can kept alive by a JS object in > a way that the GC can be aware of to address this problem. > This is a breaking change for embedders > using v8::Object::GetInternalField() as it changes the return > type. Since most v8::Value subtypes only support direct casts > from v8::Value but not v8::Data, calls like > > object->GetInternalField(index).As<v8::External>() > > needs to be updated to cast the value to v8::Value first: > > object->GetInternalField(index).As<v8::Value>().As<v8::External>() > > Bug: v8:14120 > Change-Id: I731c958d1756b9d5ee4a3e78813416cd60d1b7ca > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4707972 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Cr-Commit-Position: refs/heads/main@{#89718} Bug: v8:14120 Change-Id: I3e45d09b5c300d5eefc73e380ef21ac2bd61760c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4834471 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#89824} Refs: v8/v8@93b1a74

joyeecheung · 2023-09-08T10:57:15Z

Updated to backport the reland instead - it's been in V8 main branch for a few days, should be safe to merge back now.

nodejs-github-bot · 2023-09-08T10:58:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53812/

nodejs-github-bot · 2023-09-08T10:58:59Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5547/

nodejs-github-bot · 2023-09-08T10:59:17Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5547/

nodejs-github-bot · 2023-09-08T10:59:50Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5547/

nodejs-github-bot · 2023-09-08T10:59:54Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5548/

nodejs-github-bot · 2023-09-08T11:00:09Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5548/

nodejs-github-bot · 2023-09-08T11:02:55Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5548/

nodejs-github-bot · 2023-09-09T11:36:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53835/

nodejs-github-bot · 2023-09-10T13:25:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53863/

nodejs-github-bot · 2023-09-11T11:29:04Z

Landed in f970087

Original commit message: Reland "[api] allow v8::Data as internal field" This is a reland of commit 0aa622e12893e9921c01a34ce9507b544e599c4a The original patch tried to run a test that calls exit() in the fatal error handler in parallel, which would not work. This marked the test with TEST() to avoid running it in parallel. Original change's description: > [api] allow v8::Data as internal field > > Previously only v8::Value can be stored as internal fields. > In some cases, however, it's necessary for the embedder to > tie the lifetime of a v8::Data with the lifetime of a > JS object, and that v8::Data may not be a v8::Value, as > it can be something returned from the V8 API. One way to > keep the v8::Data alive may be to use a v8::Persistent<v8::Data> > but that can easily lead to leaks. > > This patch changes v8::Object::GetInternalField() and > v8::Object::SetInernalField() to accept v8::Data instead of just > v8::Value, so that v8::Data can kept alive by a JS object in > a way that the GC can be aware of to address this problem. > This is a breaking change for embedders > using v8::Object::GetInternalField() as it changes the return > type. Since most v8::Value subtypes only support direct casts > from v8::Value but not v8::Data, calls like > > object->GetInternalField(index).As<v8::External>() > > needs to be updated to cast the value to v8::Value first: > > object->GetInternalField(index).As<v8::Value>().As<v8::External>() > > Bug: v8:14120 > Change-Id: I731c958d1756b9d5ee4a3e78813416cd60d1b7ca > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4707972 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Cr-Commit-Position: refs/heads/main@{#89718} Bug: v8:14120 Change-Id: I3e45d09b5c300d5eefc73e380ef21ac2bd61760c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4834471 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#89824} Refs: v8/v8@93b1a74 PR-URL: nodejs#49419 Refs: v8/v8@0aa622e Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Aug 31, 2023

joyeecheung mentioned this pull request Aug 31, 2023
module: rework of memory management in vm APIs with the importModuleDynamically option #48510
Closed

gengjiawen approved these changes Aug 31, 2023
View reviewed changes

joyeecheung added the dont-land-on-v20.x label Aug 31, 2023

joyeecheung added the blocked PRs that are blocked by other issues or PRs. label Aug 31, 2023

joyeecheung force-pushed the backport-data branch from ab06393 to d08e689Compare September 7, 2023 23:09

joyeecheung added request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Sep 8, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023

github-actionsBot mentioned this pull request Sep 9, 2023
CI Reliability 2023-09-09 nodejs/reliability#660
Open
24 tasks

github-actionsBot mentioned this pull request Sep 10, 2023
CI Reliability 2023-09-10 nodejs/reliability#661
Open
19 tasks

anonrig approved these changes Sep 10, 2023
View reviewed changes

anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 10, 2023

github-actionsBot mentioned this pull request Sep 11, 2023
CI Reliability 2023-09-11 nodejs/reliability#662
Open
18 tasks

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2023

nodejs-github-bot merged commit f970087 into nodejs:mainSep 11, 2023

joyeecheung mentioned this pull request Sep 11, 2023
test-runner-watch-mode is flaky #49605
Closed

This was referenced Sep 12, 2023
CI Reliability 2023-09-12 nodejs/reliability#663
Open
CI Reliability 2023-09-13 nodejs/reliability#664
Open

joyeecheung added the dont-land-on-v18.x label Sep 13, 2023

joyeecheung mentioned this pull request Sep 15, 2023
deps: update V8 to 11.8 #49639
Closed

joyeecheung mentioned this pull request Sep 26, 2023
[v20.x] backport vm-related memory fixes #49874
Closed

RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged

Uh oh!

Uh oh!

Conversation

joyeecheung commented Aug 31, 2023

Uh oh!

nodejs-github-bot commented Aug 31, 2023

Uh oh!

joyeecheung commented Aug 31, 2023

Uh oh!

joyeecheung commented Aug 31, 2023

Uh oh!

joyeecheung commented Aug 31, 2023

Uh oh!

joyeecheung commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 10, 2023

Uh oh!

nodejs-github-bot commented Sep 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants