Skip to content

test_runner: preserve original property descriptor when mutating objects - #49433

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
ErickWendel:test_runner/mock-preserve-original-property-descriptor
Sep 3, 2023
Merged

test_runner: preserve original property descriptor when mutating objects#49433
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
ErickWendel:test_runner/mock-preserve-original-property-descriptor

Conversation

@ErickWendel

@ErickWendelErickWendel commented Sep 1, 2023

Copy link
Copy Markdown
Member

In this comment, #49397 (comment)@ljharb suggested preserving the behavior and attributes of properties as they were before the modification

cc @nodejs/test_runner

@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2023•
edited by ErickWendel
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 1, 2023
@ErickWendel
ErickWendelforce-pushed the test_runner/mock-preserve-original-property-descriptor branch from 768af5c to 3fda352CompareSeptember 1, 2023 17:15
ljharb
ljharb approved these changes Sep 1, 2023
View reviewed changes

@ljharbljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to add a test or two checking enumerability, since that's likely the only thing different with this change

Comment threadlib/internal/test_runner/mock/mock_timers.js Outdated
@ErickWendelErickWendel self-assigned this Sep 1, 2023
@ErickWendel

ErickWendel commented Sep 1, 2023

Copy link
Copy Markdown
MemberAuthor

would be good to add a test or two checking enumerability, since that's likely the only thing different with this change

Uh, good catch! Gonna do it in a few

@ErickWendel
test_runner: add test for checking the property descriptor state
77caf13
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
@ErickWendel
test_runner: refactoring functions
64f872a
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
@ErickWendel
ErickWendelforce-pushed the test_runner/mock-preserve-original-property-descriptor branch from 93a9e75 to 64f872aCompareSeptember 1, 2023 19:02
@ErickWendel

ErickWendel commented Sep 1, 2023

Copy link
Copy Markdown
MemberAuthor

would be good to add a test or two checking enumerability, since that's likely the only thing different with this change

done!

ljharb
ljharb approved these changes Sep 1, 2023
View reviewed changes

@ljharbljharb left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is way cleaner

@ErickWendelErickWendel added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53689/

@atlowChemiatlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53694/

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 3, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 3, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49433
✔ Done loading data for nodejs/node/pull/49433
----------------------------------- PR info ------------------------------------
Title test_runner: preserve original property descriptor when mutating objects (#49433)
Author Erick Wendel (@ErickWendel)
Branch ErickWendel:test_runner/mock-preserve-original-property-descriptor -> nodejs:main
Labels author ready, needs-ci, test_runner
Commits 3
- test_runner: preserve original property descriptor
- test_runner: add test for checking the property descriptor state
- test_runner: refactoring functions
Committers 1
- Erick Wendel PR-URL: https://github.com/nodejs/node/pull/49433
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Raz Luvaton Reviewed-By: Chemi Atlow Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49433
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Raz Luvaton Reviewed-By: Chemi Atlow Reviewed-By: Moshe Atlow --------------------------------------------------------------------------------
ℹ This PR was created on Fri, 01 Sep 2023 17:13:36 GMT
✔ Approvals: 4
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608049890
✔ - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608346449
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608366919
✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608411583
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-09-02T19:22:27Z: https://ci.nodejs.org/job/node-test-pull-request/53694/
- Querying data for job/node-test-pull-request/53694/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 49433
From https://github.com/nodejs/node
* branch refs/pull/49433/merge -> FETCH_HEAD
✔ Fetched commits as 0add7a8f0c92..64f872a28f86
--------------------------------------------------------------------------------
[main 9ce045d826] test_runner: preserve original property descriptor
Author: Erick Wendel Date: Fri Sep 1 14:07:12 2023 -0300
1 file changed, 137 insertions(+), 35 deletions(-)
[main 9a7621b25c] test_runner: add test for checking the property descriptor state
Author: Erick Wendel Date: Fri Sep 1 15:55:26 2023 -0300
1 file changed, 49 insertions(+)
[main 2de5750354] test_runner: refactoring functions
Author: Erick Wendel Date: Fri Sep 1 15:59:39 2023 -0300
2 files changed, 162 insertions(+), 141 deletions(-)
✔ Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test_runner: preserve original property descriptor
PR-URL: #49433

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Raz Luvaton rluvaton@gmail.com

Reviewed-By: Chemi Atlow chemi@atlow.co.il

Reviewed-By: Moshe Atlow moshe@atlow.co.il
[detached HEAD dc9c314b0f] test_runner: preserve original property descriptor

Author: Erick Wendel erick.workspace@gmail.com

Date: Fri Sep 1 14:07:12 2023 -0300

1 file changed, 137 insertions(+), 35 deletions(-)

Rebasing (3/6)

Rebasing (4/6)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test_runner: add test for checking the property descriptor state
Signed-off-by: Erick Wendel erick.workspace@gmail.com

PR-URL: #49433

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Raz Luvaton rluvaton@gmail.com

Reviewed-By: Chemi Atlow chemi@atlow.co.il

Reviewed-By: Moshe Atlow moshe@atlow.co.il
[detached HEAD 496538d949] test_runner: add test for checking the property descriptor state

Author: Erick Wendel erick.workspace@gmail.com

Date: Fri Sep 1 15:55:26 2023 -0300

1 file changed, 49 insertions(+)

Rebasing (5/6)

Rebasing (6/6)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test_runner: refactoring functions
Signed-off-by: Erick Wendel erick.workspace@gmail.com

PR-URL: #49433

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Raz Luvaton rluvaton@gmail.com

Reviewed-By: Chemi Atlow chemi@atlow.co.il

Reviewed-By: Moshe Atlow moshe@atlow.co.il
[detached HEAD 1dc3702999] test_runner: refactoring functions

Author: Erick Wendel erick.workspace@gmail.com

Date: Fri Sep 1 15:59:39 2023 -0300

2 files changed, 162 insertions(+), 141 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/6065810018

@atlowChemiatlowChemi added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 3, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 3, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8e82cfc into nodejs:mainSep 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8e82cfc

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@ErickWendel@UlisesGascon
test_runner: preserve original property descriptor
36763fa
PR-URL: #49433
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@UlisesGasconUlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@ErickWendel@targos
test_runner: preserve original property descriptor
760c982
PR-URL: #49433
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: preserve original property descriptor
089971c
PR-URL: nodejs/node#49433
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: preserve original property descriptor
7613769
PR-URL: nodejs/node#49433
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@MoLowMoLowMoLow approved these changes
@rluvatonrluvatonrluvaton approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

@ErickWendelErickWendel

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ErickWendel@nodejs-github-bot@ljharb@benjamingr@MoLow@rluvaton@atlowChemi