Skip to content

doc: cast GetInternalField() return type to v8::Value in addons.md - #49439

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fix-addons-md
Sep 7, 2023
Merged

doc: cast GetInternalField() return type to v8::Value in addons.md#49439
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fix-addons-md

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Sep 1, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Sep 1, 2023
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53724/

This was referenced Sep 5, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53762/

@github-actionsgithub-actionsBot mentioned this pull request Sep 7, 2023
Open
20 tasks
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a33a497 into nodejs:mainSep 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in a33a497

@github-actionsgithub-actionsBot mentioned this pull request Sep 8, 2023
Open
26 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung@ruyadorno
doc: cast GetInternalField() return type to v8::Value in addons.md
0471c57
For the breaking change in
https://chromium-review.googlesource.com/c/v8/v8/+/4707972
PR-URL: #49439
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+1 more reviewer
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

addonsIssues and PRs related to native addons.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung@nodejs-github-bot@lpinca@tniessen@aymen94@RaisinTen