Skip to content

test: make test-dotenv-node-options locale-independent - #49470

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-fix-dotenv-localespecific
Sep 7, 2023
Merged

test: make test-dotenv-node-options locale-independent#49470
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-fix-dotenv-localespecific

Conversation

@LiviaMedeiros

@LiviaMedeirosLiviaMedeiros commented Sep 3, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Note: I've tried to add LANG=C or LC_ALL=C to test/fixtures/dotenv/node-options.env and it didn't help. Setting process.env.LANG = 'C' in main process helps. Not sure if it's bug or feature.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 3, 2023
@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53706/

@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53711/

@atlowChemiatlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 4, 2023
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f0ebb77 into nodejs:mainSep 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in f0ebb77

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@LiviaMedeiros@ruyadorno
test: make test-dotenv-node-options locale-independent
3987094
PR-URL: #49470
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiviaMedeiros@nodejs-github-bot@lpinca@atlowChemi