test_runner: add jsdocs to MockTimers by ErickWendel · Pull Request #49476 · nodejs/node

ErickWendel · 2023-09-03T21:04:58Z

Add JSDocs for all public functions on MockTimers

cc @nodejs/test_runner

nodejs-github-bot · 2023-09-03T21:05:03Z

Review requested:

@nodejs/test_runner

Signed-off-by: Erick Wendel <erick.workspace@gmail.com>

github-actions · 2023-09-03T22:10:24Z

Fast-track has been requested by @ErickWendel. Please 👍 to approve.

benjamingr

LGTM though I think Symbol.dispose should be encouraged

Co-authored-by: Benjamin Gruenbaum <inglor@gmail.com> Co-authored-by: Chemi Atlow <chemi@atlow.co.il>

nodejs-github-bot · 2023-09-05T03:27:58Z

Commit Queue failed

- Loading data for nodejs/node/pull/49476
✘ Failed to get collaborator info from nodejs/node/README.md
Error: Couldn't find ### TSC (Technical Steering Committee) in the README
at parseCollaborators (file:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:81:11)
at getCollaborators (file:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:59:21)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async PRData.getCollaborators (file:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:74:26)
at async Promise.all (index 0)
at async PRData.getAll (file:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:58:5)
at async getMetadata (file:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/components/metadata.js:18:3)
at async main (file:///opt/hostedtoolcache/node/18.17.1/x64/lib/node_modules/node-core-utils/components/git/land.js:204:22)

https://github.com/nodejs/node/actions/runs/6079853604

nodejs-github-bot · 2023-09-05T06:43:23Z

Commit Queue failed

- Loading data for nodejs/node/pull/49476
✔ Done loading data for nodejs/node/pull/49476
----------------------------------- PR info ------------------------------------
Title test_runner: add jsdocs to MockTimers (#49476)
Author Erick Wendel (@ErickWendel)
Branch ErickWendel:test_runner/add-js-docs-to-mock -> nodejs:main
Labels fast-track, needs-ci, commit-queue-squash, test_runner
Commits 2
- test_runner: add jsdocs to MockTimers
- test_runner: apply suggestions
Committers 2
- Erick Wendel - GitHub PR-URL: https://github.com/nodejs/node/pull/49476
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Chemi Atlow ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49476
Reviewed-By: Benjamin Gruenbaum Reviewed-By: Chemi Atlow --------------------------------------------------------------------------------
ℹ This PR was created on Sun, 03 Sep 2023 21:04:58 GMT
✔ Approvals: 2
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49476#pullrequestreview-1609950368
✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49476#pullrequestreview-1609909238
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6081106699

nodejs-github-bot · 2023-09-05T06:54:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53736/

nodejs-github-bot · 2023-09-05T08:38:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53737/

nodejs-github-bot · 2023-09-05T11:41:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53740/

nodejs-github-bot · 2023-09-05T16:53:09Z

Landed in f139cc3

Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: #49476 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: nodejs/node#49476 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 3, 2023

ErickWendel self-assigned this Sep 3, 2023

test_runner: add jsdocs to MockTimers
de65b28
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>

ErickWendel force-pushed the test_runner/add-js-docs-to-mock branch from 8767073 to de65b28Compare September 3, 2023 21:10

ErickWendel added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 3, 2023

atlowChemi reviewed Sep 4, 2023
View reviewed changes

Comment threadlib/internal/test_runner/mock/mock_timers.js
Comment threadlib/internal/test_runner/mock/mock_timers.js Outdated

benjamingr approved these changes Sep 4, 2023
View reviewed changes

Comment threadlib/internal/test_runner/mock/mock_timers.js Outdated
Comment threadlib/internal/test_runner/mock/mock_timers.js Outdated
Comment threadlib/internal/test_runner/mock/mock_timers.js

test_runner: apply suggestions
823aa0c
Co-authored-by: Benjamin Gruenbaum <inglor@gmail.com> Co-authored-by: Chemi Atlow <chemi@atlow.co.il>

ErickWendel requested a review from atlowChemi September 4, 2023 18:17

atlowChemi approved these changes Sep 4, 2023
View reviewed changes

benjamingr approved these changes Sep 4, 2023
View reviewed changes

ErickWendel added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023

atlowChemi added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 5, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 5, 2023

atlowChemi added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 5, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 5, 2023

atlowChemi added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 5, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023

atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023

nodejs-github-bot merged commit f139cc3 into nodejs:mainSep 5, 2023

This was referenced Sep 6, 2023
CI Reliability 2023-09-06 nodejs/reliability#657
Open
CI Reliability 2023-09-07 nodejs/reliability#658
Open
CI Reliability 2023-09-08 nodejs/reliability#659
Open
CI Reliability 2023-09-09 nodejs/reliability#660
Open

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
test_runner: add jsdocs to MockTimers
f755e67
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: #49476 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged

targos pushed a commit that referenced this pull request Nov 27, 2023
test_runner: add jsdocs to MockTimers
5949ae0
Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: #49476 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged

Navigation Menu

Uh oh!

Uh oh!

test_runner: add jsdocs to MockTimers - #49476

test_runner: add jsdocs to MockTimers#49476
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
ErickWendel:test_runner/add-js-docs-to-mock

ErickWendel commented Sep 3, 2023•
edited
Loading

Uh oh!

nodejs-github-bot commented Sep 3, 2023

Uh oh!

github-actionsBot commented Sep 3, 2023

Uh oh!

Uh oh!

Uh oh!

benjamingr left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

ErickWendel commented Sep 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 3, 2023

Uh oh!

github-actionsBot commented Sep 3, 2023

Uh oh!

Uh oh!

Uh oh!

benjamingr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

nodejs-github-bot commented Sep 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ErickWendel commented Sep 3, 2023•
edited
Loading