Skip to content

test: fix embedtest not running code - #49502

Closed
mmomtchev wants to merge 3 commits into
nodejs:mainfrom
mmomtchev:embedtest
Closed

test: fix embedtest not running code#49502
mmomtchev wants to merge 3 commits into
nodejs:mainfrom
mmomtchev:embedtest

Conversation

@mmomtchev

@mmomtchevmmomtchev commented Sep 5, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix embedtest and add a test that tests the testing harness

Fixes#49501

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Sep 5, 2023
@mmomtchev

mmomtchev commented Sep 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@joyeecheung Maybe you should take over this PR because this is more than I bargained for

@joyeecheung

joyeecheung commented Sep 5, 2023

Copy link
Copy Markdown
Member

Thanks for reporting it, I opened #49506

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

embedtest doesn't actually run any code

3 participants

@mmomtchev@joyeecheung@nodejs-github-bot