Skip to content

doc: close a parenthesis - #49525

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
regseb:patch-1
Sep 7, 2023
Merged

doc: close a parenthesis#49525
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
regseb:patch-1

Conversation

@regseb

@regsebregseb commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Close parenthesis in Package entry points chapter:

Existing packages introducing the "exports" field will prevent consumers of the package from using any entry points that are not defined, including the package.json (e.g. require('your-package/package.json'). This will likely be a breaking change.

@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 7, 2023
@lpincalpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 7, 2023
@github-actions

github-actionsBot commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e6fce82 into nodejs:mainSep 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in e6fce82

@regseb
regseb deleted the patch-1 branch September 7, 2023 12:38
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@regseb@ruyadorno
doc: close a parenthesis
b4724e2
PR-URL: #49525
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@regseb@nodejs-github-bot@lpinca@aduh95