Skip to content

src: support multiple --env-file declarations - #49542

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:multiple-env-file
Sep 10, 2023
Merged

src: support multiple --env-file declarations#49542
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:multiple-env-file

Conversation

@anonrig

@anonriganonrig commented Sep 7, 2023•
edited
Loading

Copy link
Copy Markdown
Member

From now on, you can pass multiple --env-file arguments. Each valid config file will
override any pre-existing declarations made in previous config file.

Example:

node --env-file=.env --env-file=.development.env index.js

Ref: #49148

@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 7, 2023
@anonriganonrig mentioned this pull request Sep 5, 2023
Open
8 tasks
@anonriganonrig added the notable-change PRs with changes that should be highlighted in changelogs. label Sep 7, 2023
@github-actions

This comment was marked as resolved.

Sign in to view
GeoffreyBooth
GeoffreyBooth reviewed Sep 7, 2023
View reviewed changes
Comment threaddoc/api/cli.md Outdated
atlowChemi
atlowChemi reviewed Sep 7, 2023
View reviewed changes
Comment threaddoc/api/cli.md Outdated
@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 8, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53816/

@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53823/

@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53825/

@github-actionsgithub-actionsBot mentioned this pull request Sep 9, 2023
Open
24 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53846/

@github-actionsgithub-actionsBot mentioned this pull request Sep 10, 2023
Open
19 tasks
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Sep 10, 2023
@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ce30b4e into nodejs:mainSep 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in ce30b4e

@bricssbricss mentioned this pull request Sep 10, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request Sep 11, 2023
Open
18 tasks
UlisesGascon pushed a commit that referenced this pull request Sep 11, 2023
@anonrig@UlisesGascon
src: support multiple --env-file declarations
022f1b7
PR-URL: #49542
Refs: #49148
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon added a commit that referenced this pull request Sep 11, 2023
@UlisesGascon
2023-09-13, Version 20.7.0 (Current)
dcc3c41
Notable changes:
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
* move and rename loaders section (Geoffrey Booth) #49261
lib:
* (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
* support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
* add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
* (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975
PR-URL: #49592
@github-actionsgithub-actionsBot mentioned this pull request Sep 12, 2023
Open
19 tasks
UlisesGascon added a commit that referenced this pull request Sep 12, 2023
@UlisesGascon
2023-09-13, Version 20.7.0 (Current)
9f950df
Notable changes:
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
* move and rename loaders section (Geoffrey Booth) #49261
* add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
* (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
* support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
* add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
* (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975
PR-URL: #49592
@github-actionsgithub-actionsBot mentioned this pull request Sep 13, 2023
Open
14 tasks
UlisesGascon added a commit that referenced this pull request Sep 13, 2023
@UlisesGascon
2023-09-18, Version 20.7.0 (Current)
50ee6bf
Notable changes:
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
* move and rename loaders section (Geoffrey Booth) #49261
* add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
* (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
* support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
* add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
* (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975
PR-URL: #49592
UlisesGascon added a commit that referenced this pull request Sep 13, 2023
@UlisesGascon
2023-09-18, Version 20.7.0 (Current)
d9e2456
Notable changes:
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
* move and rename loaders section (Geoffrey Booth) #49261
* add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
* (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
* support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
* add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
* (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975
PR-URL: #49592
UlisesGascon added a commit that referenced this pull request Sep 16, 2023
@UlisesGascon
2023-09-18, Version 20.7.0 (Current)
3557c43
Notable changes:
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
* move and rename loaders section (Geoffrey Booth) #49261
* add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
* (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
* support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
* add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
* (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975
PR-URL: #49592
UlisesGascon added a commit that referenced this pull request Sep 18, 2023
@UlisesGascon
2023-09-18, Version 20.7.0 (Current)
204471c
Notable changes:
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
deps:
* upgrade npm to 10.0.0 (npm team) #49423
* upgrade npm to 10.1.0 (npm team) #49570
doc:
* move and rename loaders section (Geoffrey Booth) #49261
* add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
* (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
* support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
* add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
* (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975
PR-URL: #49592
UlisesGascon added a commit that referenced this pull request Sep 18, 2023
@UlisesGascon
2023-09-18, Version 20.7.0 (Current)
a71037e
Notable changes:
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
deps:
* upgrade npm to 10.1.0 (npm team) #49570
* upgrade npm to 10.0.0 (npm team) #49423
doc:
* move and rename loaders section (Geoffrey Booth) #49261
* add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
* (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
* support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
* add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
* (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975
PR-URL: #49592
UlisesGascon added a commit to UlisesGascon/node that referenced this pull request Sep 18, 2023
@UlisesGascon
2023-09-18, Version 20.7.0 (Current)
b651e37
Notable changes:
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) nodejs#49341
deps:
* upgrade npm to 10.1.0 (npm team) nodejs#49570
* upgrade npm to 10.0.0 (npm team) nodejs#49423
doc:
* move and rename loaders section (Geoffrey Booth) nodejs#49261
* add release key for Ulises Gascon (Ulises Gascón) nodejs#49196
lib:
* (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) nodejs#46391
src:
* support multiple `--env-file` declarations (Yagiz Nizipli) nodejs#49542
src,permission:
* add multiple allow-fs-* flags (Carlos Espa) nodejs#49047
test_runner:
* (SEMVER-MINOR) expose location of tests (Colin Ihrig) nodejs#48975
PR-URL: nodejs#49592
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@UlisesGascon@alexfernandez
2023-09-18, Version 20.7.0 (Current)
0a8bb2a
Notable changes:
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) nodejs#49341
deps:
* upgrade npm to 10.1.0 (npm team) nodejs#49570
* upgrade npm to 10.0.0 (npm team) nodejs#49423
doc:
* move and rename loaders section (Geoffrey Booth) nodejs#49261
* add release key for Ulises Gascon (Ulises Gascón) nodejs#49196
lib:
* (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) nodejs#46391
src:
* support multiple `--env-file` declarations (Yagiz Nizipli) nodejs#49542
src,permission:
* add multiple allow-fs-* flags (Carlos Espa) nodejs#49047
test_runner:
* (SEMVER-MINOR) expose location of tests (Colin Ihrig) nodejs#48975
PR-URL: nodejs#49592
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessentniessentniessen left review comments
@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
+1 more reviewer
@kibertoadkibertoadkibertoad left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.notable-changePRs with changes that should be highlighted in changelogs.review wantedPRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@GeoffreyBooth@kibertoad@tniessen@atlowChemi