Skip to content

lib: use internal fileURLToPath - #49558

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:230908_use_internal_fileURLToPath
Sep 10, 2023
Merged

lib: use internal fileURLToPath#49558
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:230908_use_internal_fileURLToPath

Conversation

@deokjinkim

@deokjinkimdeokjinkim commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

For internal usage, internal/url should be used.

Refs: #49553

@deokjinkim
lib: use internal fileURLToPath
2fea2ec
For internal usage, `internal/url` should be used.
Refs: nodejs#49553
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 8, 2023
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 8, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53818/

@github-actionsgithub-actionsBot mentioned this pull request Sep 9, 2023
Open
24 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53832/

@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53848/

@github-actionsgithub-actionsBot mentioned this pull request Sep 10, 2023
Open
19 tasks
@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b3fc917 into nodejs:mainSep 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in b3fc917

@LiviaMedeirosLiviaMedeiros mentioned this pull request Sep 10, 2023
Closed
This was referenced Sep 11, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@deokjinkim@ruyadorno
lib: use internal fileURLToPath
f62d649
For internal usage, `internal/url` should be used.
Refs: #49553
PR-URL: #49558
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@JungMinuJungMinuJungMinu approved these changes
@aduh95aduh95aduh95 approved these changes
@rluvatonrluvatonrluvaton approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@deokjinkim@nodejs-github-bot@anonrig@JungMinu@aduh95@rluvaton@atlowChemi@LiviaMedeiros