typings: fix missing property in `ExportedHooks` by aduh95 · Pull Request #49567 · nodejs/node

aduh95 · 2023-09-08T21:20:31Z

No description provided.

nodejs-github-bot · 2023-09-08T21:20:35Z

Review requested:

@nodejs/loaders

github-actions · 2023-09-08T21:20:43Z

Fast-track has been requested by @aduh95. Please 👍 to approve.

nodejs-github-bot · 2023-09-09T15:19:11Z

Commit Queue failed

- Loading data for nodejs/node/pull/49567
✔ Done loading data for nodejs/node/pull/49567
----------------------------------- PR info ------------------------------------
Title typings: fix missing property in `ExportedHooks` (#49567)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch aduh95:exported-hooks-initialize -> nodejs:main
Labels esm, fast-track, needs-ci, typings, commit-queue-squash
Commits 1
- typings: fix missing property in `ExportedHooks`
Committers 1
- Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh --------------------------------------------------------------------------------
ℹ This PR was created on Fri, 08 Sep 2023 21:20:31 GMT
✔ Approvals: 3
✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659
✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867
✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6131683938

nodejs-github-bot · 2023-09-09T15:52:46Z

Commit Queue failed

- Loading data for nodejs/node/pull/49567
✔ Done loading data for nodejs/node/pull/49567
----------------------------------- PR info ------------------------------------
Title typings: fix missing property in `ExportedHooks` (#49567)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch aduh95:exported-hooks-initialize -> nodejs:main
Labels esm, fast-track, typings, commit-queue-squash
Commits 1
- typings: fix missing property in `ExportedHooks`
Committers 1
- Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh --------------------------------------------------------------------------------
ℹ This PR was created on Fri, 08 Sep 2023 21:20:31 GMT
✔ Approvals: 3
✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659
✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867
✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6131826631

nodejs-github-bot · 2023-09-09T17:55:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53843/

nodejs-github-bot · 2023-09-09T19:23:30Z

Commit Queue failed

- Loading data for nodejs/node/pull/49567
✔ Done loading data for nodejs/node/pull/49567
----------------------------------- PR info ------------------------------------
Title typings: fix missing property in `ExportedHooks` (#49567)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch aduh95:exported-hooks-initialize -> nodejs:main
Labels esm, fast-track, typings, commit-queue-squash
Commits 1
- typings: fix missing property in `ExportedHooks`
Committers 1
- Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith Reviewed-By: Mohammed Keyvanzadeh --------------------------------------------------------------------------------
ℹ This PR was created on Fri, 08 Sep 2023 21:20:31 GMT
✔ Approvals: 3
✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659
✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867
✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222
ℹ This PR is being fast-tracked
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2023-09-09T17:55:08Z: https://ci.nodejs.org/job/node-test-pull-request/53843/
- Querying data for job/node-test-pull-request/53843/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6132755646

nodejs-github-bot · 2023-09-09T19:27:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53844/

nodejs-github-bot · 2023-09-09T20:06:30Z

Landed in 5bb0cb2

PR-URL: #49567 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: nodejs#49567 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: #49567 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: nodejs/node#49567 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

typings: fix missing property in ExportedHooks
88b2cb6

aduh95 added fast-track PRs that do not need to wait for 48 hours to land. typings labels Sep 8, 2023

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 8, 2023

GeoffreyBooth approved these changes Sep 8, 2023
View reviewed changes

JakobJingleheimer approved these changes Sep 9, 2023
View reviewed changes

UlisesGascon approved these changes Sep 9, 2023
View reviewed changes

VoltrexKeyva approved these changes Sep 9, 2023
View reviewed changes

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 9, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2023

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 9, 2023

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 9, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 9, 2023

GeoffreyBooth added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 9, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 9, 2023

MoLow approved these changes Sep 9, 2023
View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2023

nodejs-github-bot merged commit 5bb0cb2 into nodejs:mainSep 9, 2023

aduh95 deleted the exported-hooks-initialize branch September 9, 2023 22:07

This was referenced Sep 10, 2023
CI Reliability 2023-09-10 nodejs/reliability#661
Open
CI Reliability 2023-09-11 nodejs/reliability#662
Open
CI Reliability 2023-09-12 nodejs/reliability#663
Open

joyeecheung mentioned this pull request Sep 12, 2023
parallel/test-tls-socket-close is flaky #49628
Closed

This was referenced Sep 13, 2023
CI Reliability 2023-09-13 nodejs/reliability#664
Open
CI Reliability 2023-09-14 nodejs/reliability#665
Open

This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged

targos mentioned this pull request Nov 11, 2023
[v18.x] Backport most ESM and customization hook changes #50669
Closed

targos added the backported-to-v18.x label Nov 23, 2023

targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged

Navigation Menu

Uh oh!

Uh oh!

typings: fix missing property in `ExportedHooks` - #49567

typings: fix missing property in `ExportedHooks`#49567
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:exported-hooks-initialize

aduh95 commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

github-actionsBot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

aduh95 commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 8, 2023

Uh oh!

github-actionsBot commented Sep 8, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

nodejs-github-bot commented Sep 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants