Skip to content

test_runner: fix test runner watch mode when no positional arguments - #49578

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:watch-mode-with-test
Sep 14, 2023
Merged

test_runner: fix test runner watch mode when no positional arguments#49578
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:watch-mode-with-test

Conversation

@MoLow

@MoLowMoLow commented Sep 9, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #49617
I cannot reproduce the original error reported in #49544
but this fixes the issue in the comment

@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 9, 2023
@Gabriel-Tapes

Gabriel-Tapes commented Sep 11, 2023

Copy link
Copy Markdown

I cannot reproduce the original error reported in #49544

The issue I reported in #49544 is probably related to the compilation done by Arch Linux, so I'm closing it.

@atlowChemiatlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. test_runner Issues and PRs related to the test runner subsystem. watch-mode Issues and PRs related to watch mode labels Sep 11, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53896/

@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53899/

@github-actionsgithub-actionsBot mentioned this pull request Sep 12, 2023
Open
19 tasks
@LinkgoronLinkgoron mentioned this pull request Sep 12, 2023
Closed
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53916/

@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53918/

This was referenced Sep 13, 2023
Open
Open
@MoLow
MoLowforce-pushed the watch-mode-with-test branch from f0d3675 to faa2effCompareSeptember 14, 2023 05:49
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53947/

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 1a4ae46 into nodejs:mainSep 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1a4ae46

@MoLow
MoLow deleted the watch-mode-with-test branch September 14, 2023 11:48
This was referenced Sep 15, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@MoLow@ruyadorno
test_runner: fix test runner watch mode when no positional arguments
7686551
PR-URL: #49578Fixes: #49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@MoLow@targos
test_runner: fix test runner watch mode when no positional arguments
e459598
PR-URL: #49578Fixes: #49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix test runner watch mode when no positional
751e807
PR-URL: nodejs/node#49578Fixes: nodejs/node#49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix test runner watch mode when no positional
be1211d
PR-URL: nodejs/node#49578Fixes: nodejs/node#49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.watch-modeIssues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'node --test --watch' fails: node: --watch requires specifying a file

6 participants

@MoLow@nodejs-github-bot@Gabriel-Tapes@benjamingr@UlisesGascon@atlowChemi