Skip to content

[v20.x backport] stream: improve tee perf by reduce ReflectConstruct usages - #49620

Closed
rluvaton wants to merge 1 commit into
nodejs:v20.x-stagingfrom
rluvaton:backport-49546-to-v20.x
Closed

[v20.x backport] stream: improve tee perf by reduce ReflectConstruct usages#49620
rluvaton wants to merge 1 commit into
nodejs:v20.x-stagingfrom
rluvaton:backport-49546-to-v20.x

Conversation

@rluvaton

@rluvatonrluvaton commented Sep 12, 2023•
edited
Loading

Copy link
Copy Markdown
Member

also added more webstream creation benchmarks

PR-URL: #49546
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. v20.x web streams labels Sep 12, 2023
@rluvatonrluvaton changed the title stream: improve tee perf by reduce ReflectConstruct usages[v20.x backport] stream: improve tee perf by reduce ReflectConstruct usagesSep 12, 2023
@rluvatonrluvaton mentioned this pull request Sep 12, 2023
Merged
@rluvaton
stream: improve tee perf by reduce ReflectConstruct usages
3f7b05e
also added more webstream creation benchmarks
PR-URL: nodejs#49546
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@rluvaton
rluvatonforce-pushed the backport-49546-to-v20.x branch from 8eb0194 to 3f7b05eCompareSeptember 12, 2023 13:41
@rluvatonrluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53912/

@github-actionsgithub-actionsBot mentioned this pull request Sep 13, 2023
Open
14 tasks
mcollina
mcollina approved these changes Sep 13, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

UlisesGascon pushed a commit that referenced this pull request Sep 13, 2023
@rluvaton@UlisesGascon
stream: improve tee perf by reduce ReflectConstruct usages
8aac95d
also added more webstream creation benchmarks
PR-URL: #49546
Backport-PR-URL: #49620
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@UlisesGascon

UlisesGascon commented Sep 13, 2023

Copy link
Copy Markdown
Member

Landed in 8aac95d

This was referenced Sep 14, 2023
Open
Open
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rluvaton@nodejs-github-bot@UlisesGascon@mcollina@benjamingr