Skip to content

src: use SNAPSHOT_SERDES to log snapshot ser/deserialization - #49637

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
joyeecheung:mksnapshot-log-v
Sep 18, 2023
Merged

src: use SNAPSHOT_SERDES to log snapshot ser/deserialization#49637
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
joyeecheung:mksnapshot-log-v

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Sep 13, 2023

Copy link
Copy Markdown
Member

To avoid clobbering output of MKSNAPSHOT

@joyeecheung
src: use SNAPSHOT_SERDES to log snapshot ser/deserialization
6be50bc
To avoid clobbering output of MKSNAPSHOT
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2023
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Sep 13, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53927/

This was referenced Sep 14, 2023
Open
Open
@joyeecheung

joyeecheung commented Sep 15, 2023

Copy link
Copy Markdown
MemberAuthor

@nodejs/startup @nodejs/cpp-reviewers Can I have some reviews please?

@joyeecheung

joyeecheung commented Sep 15, 2023

Copy link
Copy Markdown
MemberAuthor

Ran clang-format to make linter happy..

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53966/

@github-actionsgithub-actionsBot mentioned this pull request Sep 16, 2023
Open
25 tasks
@github-actionsgithub-actionsBot mentioned this pull request Sep 17, 2023
Open
32 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54018/

@github-actionsgithub-actionsBot mentioned this pull request Sep 18, 2023
Open
33 tasks
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54026/

@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54032/

@joyeecheungjoyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 18, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b03a757 into nodejs:mainSep 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in b03a757

This was referenced Sep 19, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung@ruyadorno
src: use SNAPSHOT_SERDES to log snapshot ser/deserialization
f611583
To avoid clobbering output of MKSNAPSHOT
PR-URL: #49637
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.debuggerIssues and PRs related to the debugger subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joyeecheung@nodejs-github-bot@jasnell@RaisinTen