doc: remove `@anonrig` from performance initiative by anonrig · Pull Request #49641 · nodejs/node

anonrig · 2023-09-13T20:44:31Z

I'll continue working on performance but I don't feel comfortable being the champion of the performance strategic initiative anymore.

nodejs-github-bot · 2023-09-13T20:44:35Z

Review requested:

@nodejs/tsc

bnb

❤️

MoLow

Your work is highly appreciated, sorry to see you step back

Jarred-Sumner · 2023-09-14T00:10:37Z

i'm sorry

joshmanders · 2023-09-14T03:09:42Z

I wish the community wasn't so toxic. Thank you for all your hard work. <3

JoaoOtavioS · 2023-09-14T03:16:05Z

Thank you for everything you did.

[in Portuguese] Obrigado por tudo que fez e continua fazendo nesta comunidade, acredito que comentários ruins sempre existirão em todo lugar, raramente vejo algum brasileiro além do Erick Wendel tão empolgado com suas contribuições, portanto acho importante registrar aqui um pequeno agradecimento. Obrigado novamente.

trivikr · 2023-09-14T05:58:36Z

Thank you, @anonrig, for your valuable contributions to improving Node.js performance ❤️

I hope you come back stronger after a brief break, to champion the performance strategic initiative again!

fox1t · 2023-09-14T06:34:05Z

This makes me so sad. The worst part of the Internet fucked up the good part of it again. Thanks for everything you did, and you will do from now on.

mcollina

Lgtm

manekinekko · 2023-09-14T07:46:16Z

Thank you for your valuable contributions @anonrig ❤️

brunogrcsada · 2023-09-14T08:38:37Z

Thank you @anonrig for all of the hours you have put in, and like everyone here I'm so sorry about all of the toxicity at the moment!

bdbch · 2023-09-14T08:38:55Z

While I tried out many NPM alternatives I always came back to NPM. Thanks for your work – I can't imagine the pressure / feeling you have. I always feel like I'm a worse developer than others but being consumed by a hypetrain must feel super bad. You have my sympathies.

People really need to chill and realize that there is a human behind every line of code (most of the time).

mertcanaltin · 2023-09-14T08:49:17Z

Thank you very much for everything ❤️

Cadienvan · 2023-09-14T09:45:13Z

I can't tell you how much I appreciate you and the job you do daily for the Node project.

nigelnindodev · 2023-09-14T11:20:24Z

Damn. Keep on with the good work in whatever you choose to focus on next.

tony-go

Really sad to see this. Really appreciate your energy, @anonrig; thanks to this energy, I learned to push back my fear about touching the codebase.

Keep that please 🙏🏼

Love you bro ❤️

ovflowd

This is the sort of Pull Request that approving just feels wrong.

I'm so sorry for everything you went through, and I hope you're able to take some quality personal time.

Qard

I greatly appreciate all the amazing work you've done for Node.js performance! We need more people that care so much about improving the performance of Node.js. Take care, Yagiz! ❤️

rluvaton · 2023-09-14T16:48:58Z

As soon as I saw that I said noooooooo, wish you the best!

sheplu

Feels wrong to LGTM so LBTM !

You did and are doing amazing work! Thanks for all your contributions

cozzbie

😢

github-actions · 2023-09-14T19:13:36Z

Fast-track has been requested by @benjamingr. Please 👍 to approve.

nodejs-github-bot · 2023-09-14T19:18:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/49641
✔ Done loading data for nodejs/node/pull/49641
----------------------------------- PR info ------------------------------------
Title doc: remove `@anonrig` from performance initiative (#49641)
Author Yagiz Nizipli (@anonrig)
Branch anonrig:perf-strategic-initiative -> nodejs:main
Labels doc, fast-track, author ready
Commits 1
- doc: remove `@anonrig` from performance initiative
Committers 1
- Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/49641
Reviewed-By: Tierney Cyren Reviewed-By: Benjamin Gruenbaum Reviewed-By: Moshe Atlow Reviewed-By: James M Snell Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen Reviewed-By: Antoine du Hamel Reviewed-By: Marco Ippolito Reviewed-By: Claudio Wunder Reviewed-By: Stephen Belanger Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49641
Reviewed-By: Tierney Cyren Reviewed-By: Benjamin Gruenbaum Reviewed-By: Moshe Atlow Reviewed-By: James M Snell Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen Reviewed-By: Antoine du Hamel Reviewed-By: Marco Ippolito Reviewed-By: Claudio Wunder Reviewed-By: Stephen Belanger Reviewed-By: Tobias Nießen --------------------------------------------------------------------------------
ℹ This PR was created on Wed, 13 Sep 2023 20:44:31 GMT
✔ Approvals: 11
✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625430602
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625509384
✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625535709
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625548463
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626092103
✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626250563
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626261122
✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626399738
✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/49641#pullrequestreview-1627144546
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/49641#pullrequestreview-1627158595
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1627214544
ℹ This PR is being fast-tracked
✘ Last GitHub CI failed
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6189910533

Trott · 2023-09-14T19:21:44Z

Landed in ba28cd8

doc: remove @anonrig from performance initiative
3312e73

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 13, 2023

bnb approved these changes Sep 13, 2023
View reviewed changes

benjamingr approved these changes Sep 13, 2023
View reviewed changes

MoLow approved these changes Sep 13, 2023
View reviewed changes

UlisesGascon approved these changes Sep 13, 2023
View reviewed changes

jasnell approved these changes Sep 13, 2023
View reviewed changes

This comment has been minimized.
Sign in to view

mcollina approved these changes Sep 14, 2023
View reviewed changes

RaisinTen approved these changes Sep 14, 2023
View reviewed changes

RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 14, 2023

aduh95 approved these changes Sep 14, 2023
View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023

marco-ippolito approved these changes Sep 14, 2023
View reviewed changes

tony-go approved these changes Sep 14, 2023
View reviewed changes

ovflowd approved these changes Sep 14, 2023
View reviewed changes

Qard approved these changes Sep 14, 2023
View reviewed changes

tniessen approved these changes Sep 14, 2023
View reviewed changes

sheplu approved these changes Sep 14, 2023
View reviewed changes

cozzbie reviewed Sep 14, 2023
View reviewed changes

nodejs deleted a comment from mikelerch Sep 14, 2023

nodejs locked as too heated and limited conversation to collaborators Sep 14, 2023

benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 14, 2023

nodejs unlocked this conversation Sep 14, 2023

benjamingr added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Sep 14, 2023

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 14, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 14, 2023

nodejs locked as too heated and limited conversation to collaborators Sep 14, 2023

Trott closed this Sep 14, 2023

Uh oh!

Uh oh!

Conversation

anonrig commented Sep 13, 2023

Uh oh!

nodejs-github-bot commented Sep 13, 2023

Uh oh!

bnb left a comment

Choose a reason for hiding this comment

Uh oh!

MoLow left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Jarred-Sumner commented Sep 14, 2023

Uh oh!

joshmanders commented Sep 14, 2023

Uh oh!

JoaoOtavioS commented Sep 14, 2023

Uh oh!

trivikr commented Sep 14, 2023

Uh oh!

fox1t commented Sep 14, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

manekinekko commented Sep 14, 2023

Uh oh!

brunogrcsada commented Sep 14, 2023

Uh oh!

bdbch commented Sep 14, 2023

Uh oh!

mertcanaltin commented Sep 14, 2023

Uh oh!

Cadienvan commented Sep 14, 2023

Uh oh!

nigelnindodev commented Sep 14, 2023

Uh oh!

tony-go left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

Qard left a comment

Choose a reason for hiding this comment

Uh oh!

rluvaton commented Sep 14, 2023

Uh oh!

sheplu left a comment

Choose a reason for hiding this comment

Uh oh!

cozzbie left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Sep 14, 2023

Uh oh!

nodejs-github-bot commented Sep 14, 2023

Uh oh!

Trott commented Sep 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants