Skip to content

errors: improve formatList in errors.js - #49642

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Uzlopak:improve-format-list
Sep 29, 2023
Merged

errors: improve formatList in errors.js#49642
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Uzlopak:improve-format-list

Conversation

@Uzlopak

@UzlopakUzlopak commented Sep 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR improves formatLIst in errors.js
The benchmarks:

main:

aras@aras-Lenovo-Legion-5-17ARH05H:~/workspace/node$ ./node benchmark/error/format-list.js error/format-list.js input="" n=10000000: 19,674,229.0009035
error/format-list.js input="a" n=10000000: 17,898,703.51886578
error/format-list.js input="a,b" n=10000000: 8,773,227.708163619
error/format-list.js input="a,b,c" n=10000000: 5,988,210.708969075

PR:

aras@aras-Lenovo-Legion-5-17ARH05H:~/workspace/node$ ./node benchmark/error/format-list.js error/format-list.js input="" n=10000000: 544,845,141.1173433
error/format-list.js input="a" n=10000000: 543,086,471.205501
error/format-list.js input="a,b" n=10000000: 37,940,629.811950795
error/format-list.js input="a,b,c" n=10000000: 6,147,421.564903789

@nodejs-github-botnodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Sep 14, 2023
@UzlopakUzlopak changed the title perf: improve formatList in errors.jsperf: improve performance of formatList in errors.jsSep 14, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53942/

@Uzlopak

Uzlopak commented Sep 14, 2023

Copy link
Copy Markdown
ContributorAuthor

@anonrig
Can you please add the performance tags to my PRs please?

@anonriganonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 14, 2023
LiviaMedeiros
LiviaMedeiros reviewed Sep 14, 2023
View reviewed changes
Comment threadlib/internal/errors.js Outdated
@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53952/

@mscdexmscdex changed the title perf: improve performance of formatList in errors.jserrors: improve formatList in errors.jsSep 15, 2023
@Uzlopak

Uzlopak commented Sep 18, 2023

Copy link
Copy Markdown
ContributorAuthor

@anonrig What is necessary to get this PR merged?

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@anonrig

anonrig commented Sep 25, 2023

Copy link
Copy Markdown
Member

When CI finishes, we can land this PR.

@anonrig

anonrig commented Sep 25, 2023

Copy link
Copy Markdown
Member

Pending benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1418/

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54224/

@github-actionsgithub-actionsBot mentioned this pull request Sep 27, 2023
Open
21 tasks
@github-actionsgithub-actionsBot mentioned this pull request Sep 28, 2023
Open
19 tasks
@H4adH4ad mentioned this pull request Sep 29, 2023
Open
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54349/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 4f84a3d into nodejs:mainSep 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4f84a3d

@Uzlopak
Uzlopak deleted the improve-format-list branch September 29, 2023 11:07
@RafaelGSSRafaelGSS mentioned this pull request Oct 9, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@Uzlopak@targos
errors: improve formatList in errors.js
e66991e
PR-URL: #49642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@Uzlopak@debadree25
errors: improve formatList in errors.js
b3feb52
PR-URL: nodejs#49642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@aduh95aduh95aduh95 approved these changes
@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.errorsIssues and PRs related to JavaScript errors originated in Node.js core.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Uzlopak@nodejs-github-bot@anonrig@aduh95@LiviaMedeiros