bootstrap: use internal.url instead of url

[LiviaMedeiros]

Refs: #49590 (comment)

Not sure if it might break any binary compatibility that would cause high semverness, or cause any significant regression.

cc @nodejs/process

[nodejs-github-bot]

Review requested:

• @nodejs/startup

[joyeecheung]

I think we should keep it. The reason why it's here is to include url in the snapshot so that when users require('url') it is faster.

[LiviaMedeiros]

Is there performance difference between importing it unconditionally here, and explicit import in user-provided snapshot code?
I'm curious, why we should unconditionally speed up url but not any other popular module.

[aduh95]

I'm curious, why we should unconditionally speed up url but not any other popular module.

What do you mean "popular module"? I think the goal is to bootstrap all the builtin modules so they're in the snapshot, unfortunately not all of them are snapshotable.

[LiviaMedeiros]

Ah, I was under impression from

node/lib/internal/bootstrap/switches/is_main_thread.js

Line 290 in 5d97431

// Needed by the module loader and generally needed everywhere.

that we only pre-require modules that are necessary for loading process that happens in 100% cases.

If we want to include all possible builtins in snapshot, it indeed must stay.