Skip to content

src: remove unused variable - #49665

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:unused-var
Sep 17, 2023
Merged

src: remove unused variable#49665
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:unused-var

Conversation

@targos

@targostargos commented Sep 15, 2023

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 15, 2023
@targos

targos commented Sep 15, 2023

Copy link
Copy Markdown
MemberAuthor

Not sure why it wasn't failing elsewhere. I'm opening this because of https://github.com/nodejs/node/actions/runs/6198046200/job/16827755271

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53970/

@github-actionsgithub-actionsBot mentioned this pull request Sep 16, 2023
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53975/

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 16, 2023
@github-actionsgithub-actionsBot mentioned this pull request Sep 17, 2023
Open
32 tasks
GeoffreyBooth
GeoffreyBooth approved these changes Sep 17, 2023
View reviewed changes

@GeoffreyBoothGeoffreyBooth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs like this are my favorite PRs.

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 36ab510 into nodejs:mainSep 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in 36ab510

This was referenced Sep 18, 2023
Open
Open
@ruyadorno

ruyadorno commented Sep 28, 2023

Copy link
Copy Markdown
Member

This commit does not land cleanly on v20.x-staging and will need manual backport in case we want it in v20.

@RafaelGSSRafaelGSS mentioned this pull request Oct 9, 2023
Merged
targos added a commit that referenced this pull request Nov 11, 2023
@targos
src: remove unused variable
5a2351d
PR-URL: #49665
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
@targos
targos deleted the unused-var branch November 12, 2023 10:47
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@lpincalpincalpinca approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
@richardlaurichardlaurichardlau approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@targos@nodejs-github-bot@ruyadorno@jasnell@GeoffreyBooth@lpinca@UlisesGascon@richardlau@aduh95