Skip to content

esm: fix return type of import.meta.resolve - #49698

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:import-meta-resolve
Sep 20, 2023
Merged

esm: fix return type of import.meta.resolve#49698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:import-meta-resolve

Conversation

@aduh95

@aduh95aduh95 commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Fixes: #49695

@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 18, 2023
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 18, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54039/

guybedford
guybedford requested changes Sep 18, 2023
View reviewed changes
Comment threadlib/internal/modules/esm/initialize_import_meta.js Outdated
@github-actionsgithub-actionsBot mentioned this pull request Sep 19, 2023
Open
32 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54052/

@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54061/

@GeoffreyBoothGeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 19, 2023
@GeoffreyBoothGeoffreyBooth mentioned this pull request Sep 19, 2023
Closed
@github-actionsgithub-actionsBot mentioned this pull request Sep 20, 2023
Open
27 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 20b996d into nodejs:mainSep 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in 20b996d

This was referenced Sep 21, 2023
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95@ruyadorno
esm: fix return type of import.meta.resolve
8a6f5fb
PR-URL: #49698Fixes: #49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95@targos
esm: fix return type of import.meta.resolve
44b345c
PR-URL: nodejs#49698Fixes: nodejs#49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@targostargos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95@targos
esm: fix return type of import.meta.resolve
46d730a
PR-URL: #49698
Backport-PR-URL: #50669Fixes: #49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: fix return type of import.meta.resolve
b04a64e
PR-URL: nodejs/node#49698
Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: fix return type of import.meta.resolve
32dda85
PR-URL: nodejs/node#49698
Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#49695
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@Josh-CenaJosh-Cena mentioned this pull request Aug 6, 2024
Closed
@skyclouds2001skyclouds2001 mentioned this pull request Nov 10, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@guybedfordguybedfordguybedford approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

import.meta.resolve(…) is documented to return a string, but returns a URL object

5 participants

@aduh95@nodejs-github-bot@GeoffreyBooth@guybedford@targos