Uh oh!
There was an error while loading. Please reload this page.
fs: improve error performance of chownSync - #49748
Closed
anonrig wants to merge 3 commits into
Closed
Conversation
nodejs-github-bot
commented
Sep 21, 2023
Collaborator
anonrig
commented
Sep 21, 2023
MemberAuthor
cc @nodejs/cpp-reviewers |
RaisinTen
approved these changes
Sep 22, 2023
Uh oh!
There was an error while loading. Please reload this page.
targos
reviewed
Sep 22, 2023
Uh oh!
There was an error while loading. Please reload this page.
anonrigforce-pushed
the
fs-improve-chownsync
branch
from
September 22, 2023 21:39
a67ad16 to
187fb83CompareMember
Have you tried typing this function in the REPL and see if the system call happens before you type enter? (perhaps both our REPL and the DevTools console, we use different flags for them) |
nodejs-github-bot
commented
Sep 25, 2023
Collaborator
joyeecheung
approved these changes
Sep 25, 2023
anonrigforce-pushed
the
fs-improve-chownsync
branch
from
September 26, 2023 15:28
86a17b5 to
d1ed9ffCompareanonrig
commented
Sep 26, 2023
MemberAuthor
Force pushed to resolve conflicts. |
nodejs-github-bot
commented
Sep 26, 2023
Collaborator
joyeecheung
left a comment
Member
There was a problem hiding this comment.
I just realized that this is not the right way to change the error throwing behavior. See #49593 (comment)
19 tasks
targos
removed their request for review
September 28, 2023 13:50
aduh95
commented
Sep 29, 2023
Contributor
This needs a rebase |
anonrig
commented
Sep 29, 2023
MemberAuthor
Closing in favor of #49962 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/performance#106