lib: improve performance of validateStringArray and validateBooleanArray

[Uzlopak]

instead of calling the validateString/validateBoolean function, where we are forced to create strings, which we potentially dont need, we create the string only when needed.

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1423

[anonrig]

Since you are creating a new benchmark suite, you need to also create the appropriate test for it. Similar to https://github.com/nodejs/node/blob/main/test/benchmark/test-bechmark-readline.js

[Uzlopak]

@anonrig
@mscdex
PTAL

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54153/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54201/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54203/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54219/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54225/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54240/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54257/

[Uzlopak]

Can this please be merged?

I think I improved the performance of parseFileMode and I would like to use the benchmark in this PR.

functionparseFileMode(value,name,def){value??=def;if(typeofvalue==='string'){if(value===''){thrownewERR_INVALID_ARG_VALUE(name,value,modeDesc);}letresult=0;for(leti=0;i<value.length;++i){result<<=3;switch(value[i]){case'7':
result+=7;break;case'6':
result+=6;break;case'5':
result+=5;break;case'4':
result+=4;break;case'3':
result+=3;break;case'2':
result+=2;break;case'1':
result+=1;break;case'0':
break;default:
thrownewERR_INVALID_ARG_VALUE(name,value,modeDesc);}}returnresult;}validateUint32(value,name);returnvalue;}

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54271/

[targos]

It needs a benchmark run

[Uzlopak]

@anonrig
@aduh95

can one of you please run the benchmarks?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54656/

[Uzlopak]

@aduh95

The failing tests have to be unrelated. Can you retrigger the tests, please? or should i rebase, because the fixes for the failing tests is in master already?

[Uzlopak]

@aduh95
@anonrig
Whats up? Can we merge?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55108/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55126/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55130/

[Uzlopak]

@aduh95
@anonrig

Tests finally pass. Lets merge:)?

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/49756
✔ Done loading data for nodejs/node/pull/49756
----------------------------------- PR info ------------------------------------
Title lib: improve performance of validateStringArray and validateBooleanArray (#49756)
Author Aras Abbasi (@Uzlopak)
Branch Uzlopak:improve-perf-array-validators -> nodejs:main
Labels performance, author ready, needs-ci, needs-benchmark-ci
Commits 1
- lib: improve performance of validateStringArray and validateBooleanArray
Committers 1
- uzlopak PR-URL: https://github.com/nodejs/node/pull/49756
Reviewed-By: Yagiz Nizipli Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49756
Reviewed-By: Yagiz Nizipli Reviewed-By: Trivikram Kamat --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - lib: improve performance of validateStringArray and validateBooleanArray
ℹ This PR was created on Thu, 21 Sep 2023 21:54:17 GMT
✔ Approvals: 2
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49756#pullrequestreview-1641142923
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/49756#pullrequestreview-1641181220
✔ Last GitHub CI successful
ℹ Last Benchmark CI on 2023-09-27T13:36:16Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1423
ℹ Last Full PR CI on 2023-10-22T19:56:46Z: https://ci.nodejs.org/job/node-test-pull-request/55130/
- Querying data for job/node-test-pull-request/55130/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6606164183

[Uzlopak]

[nodejs-github-bot]

Landed in a58ffad