Skip to content

[v18.x backport] test_runner: add shards support - #49762

Closed
rluvaton wants to merge 1 commit into
nodejs:v18.x-stagingfrom
rluvaton:backport-48639-to-v18.x
Closed

[v18.x backport] test_runner: add shards support#49762
rluvaton wants to merge 1 commit into
nodejs:v18.x-stagingfrom
rluvaton:backport-48639-to-v18.x

Conversation

@rluvaton

@rluvatonrluvaton commented Sep 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

PR-URL: #48639
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v18.x labels Sep 22, 2023
@rluvatonrluvaton changed the title test_runner: add shards support[v18.x backport] test_runner: add shards supportSep 22, 2023
@rluvatonrluvaton mentioned this pull request Sep 22, 2023
Merged
5 tasks
@rluvatonrluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
rluvaton
rluvaton commented Sep 22, 2023
View reviewed changes
Comment threaddoc/api/cli.md Outdated
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54146/

@rluvaton
rluvatonforce-pushed the backport-48639-to-v18.x branch from 4b06059 to cb8763fCompareSeptember 22, 2023 08:37
@rluvatonrluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54147/

@rluvaton
rluvatonforce-pushed the backport-48639-to-v18.x branch from cb8763f to 5e2af43CompareSeptember 22, 2023 09:02
@rluvatonrluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54149/

@rluvaton
test_runner: add shards support
4dcd96b
PR-URL: nodejs#48639
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@rluvaton
rluvatonforce-pushed the backport-48639-to-v18.x branch from 5e2af43 to 4dcd96bCompareSeptember 22, 2023 10:48
@rluvatonrluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54150/

This was referenced Sep 23, 2023
Open
Open
@joyeecheungjoyeecheung mentioned this pull request Sep 25, 2023
Closed
@targos

targos commented Oct 28, 2023

Copy link
Copy Markdown
Member

Landed in b55eb2a

@targostargos closed this Oct 28, 2023
targos pushed a commit that referenced this pull request Oct 28, 2023
@rluvaton@targos
test_runner: add shards support
b55eb2a
PR-URL: #48639
Backport-PR-URL: #49762
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@rluvaton
rluvaton deleted the backport-48639-to-v18.x branch October 28, 2023 15:46
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add shards support
90b7c8d
PR-URL: nodejs/node#48639
Backport-PR-URL: nodejs/node#49762
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add shards support
20e3c93
PR-URL: nodejs/node#48639
Backport-PR-URL: nodejs/node#49762
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos left review comments

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rluvaton@nodejs-github-bot@targos