Skip to content

test: replace forEach with for of in test-buffer-slice.js - #49785

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
CorrWu:main
Nov 10, 2023
Merged

test: replace forEach with for of in test-buffer-slice.js#49785
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
CorrWu:main

Conversation

@CorrWu

@CorrWuCorrWu commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2023
tniessen
tniessen reviewed Sep 22, 2023
View reviewed changes

@tniessentniessen left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CorrWu. According to our commit message guidelines, the commit message should begin with test: replace .... You can follow these instructions to change the commit message.

@tniessentniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 22, 2023
@CorrWuCorrWu changed the title Replace forEach with for of in test-buffer-slice.jstest: replace forEach with for of in test-buffer-slice.jsSep 23, 2023
@CorrWu

CorrWu commented Sep 23, 2023

Copy link
Copy Markdown
ContributorAuthor

Just fixed it. Is it good now?

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54233/

@github-actionsgithub-actionsBot mentioned this pull request Sep 28, 2023
Open
19 tasks
@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55151/

This was referenced Oct 24, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55428/

@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55476/

@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a5a6fef into nodejs:mainNov 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in a5a6fef

targos pushed a commit that referenced this pull request Nov 11, 2023
@CorrWu@targos
test: replace forEach with for of
96907b5
PR-URL: #49785
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@CorrWu@targos
test: replace forEach with for of
1d52a57
PR-URL: #49785
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@CorrWu@UlisesGascon
test: replace forEach with for of
03ba28f
PR-URL: #49785
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CorrWu@nodejs-github-bot@jasnell@lpinca@tniessen@debadree25