Skip to content

test: replace forEach() with for loop - #49795

Closed
chandrakhishma wants to merge 2 commits into
nodejs:mainfrom
chandrakhishma:newbranch
Closed

test: replace forEach() with for loop#49795
chandrakhishma wants to merge 2 commits into
nodejs:mainfrom
chandrakhishma:newbranch

Conversation

@chandrakhishma

@chandrakhishmachandrakhishma commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

test: Replace foreach loop with for in test-trace-events-http.js

@chandrakhishma
test: replace forEach() with for loop
c5cc1b6
test: Replace foreach loop with for in test-trace-events-http.js
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2023
@tniessentniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 22, 2023
@tniessentniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54169/

@github-actionsgithub-actionsBot mentioned this pull request Sep 24, 2023
Open
20 tasks
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2023
lpinca
lpinca approved these changes Nov 2, 2023
View reviewed changes
Comment threadtest/parallel/test-trace-events-http.js Outdated
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55414/

@lpinca

lpinca commented Nov 2, 2023

Copy link
Copy Markdown
Member

Landed in 791611a.

@lpincalpinca closed this Nov 2, 2023
lpinca pushed a commit that referenced this pull request Nov 2, 2023
@chandrakhishma@lpinca
test: replace forEach() with for...of in test-trace-events-http
791611a
PR-URL: #49795
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@chandrakhishma@targos
test: replace forEach() with for...of in test-trace-events-http
28b866c
PR-URL: #49795
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@chandrakhishma@targos
test: replace forEach() with for...of in test-trace-events-http
f40435d
PR-URL: #49795
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@chandrakhishma@UlisesGascon
test: replace forEach() with for...of in test-trace-events-http
f885dfe
PR-URL: #49795
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chandrakhishma@nodejs-github-bot@lpinca@tniessen