Skip to content

test: replace forEach with for..of in test-http2-client-destroy.js - #49820

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
niyashiyas:test-3
Oct 21, 2023
Merged

test: replace forEach with for..of in test-http2-client-destroy.js#49820
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
niyashiyas:test-3

Conversation

@niyashiyas

@niyashiyasniyashiyas commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

Replaced forEach with for..of in test-http2-client-destroy.js

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2023
@tniessentniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
tniessen
tniessen reviewed Sep 23, 2023
View reviewed changes
Comment threadtest/parallel/test-http2-client-destroy.js Outdated
@tniessen

tniessen commented Sep 24, 2023

Copy link
Copy Markdown
Member

Please update all your PRs to comply with our commit message guidelines. In particular, there should be a lowercase imperative verb after the test: prefix (e.g., test: replace ... instead of test: Replaced ...). You can find instructions for updating an existing PR here.

@niyashiyasniyashiyas changed the title test: Replaced forEach with for..of in test-http2-client-destroy.jstest: replace forEach with for..of in test-http2-client-destroy.jsSep 30, 2023
@niyashiyas

niyashiyas commented Sep 30, 2023

Copy link
Copy Markdown
ContributorAuthor

@tniessen, I have redid all the commit messages as per your instructions.
Please review it, when you are free ..
Thanks a ton !

lpinca
lpinca reviewed Oct 14, 2023
View reviewed changes
Comment threadtest/parallel/test-http2-client-destroy.js Outdated
@lpincalpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54782/

@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54970/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit fd562ef into nodejs:mainOct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in fd562ef

targos pushed a commit that referenced this pull request Oct 23, 2023
@niyashiyas@targos
test: replace forEach with for..of in test-http2-client-destroy.js
af31d51
PR-URL: #49820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas@targos
test: replace forEach with for..of in test-http2-client-destroy.js
8c15281
PR-URL: #49820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@niyashiyas@targos
test: replace forEach with for..of in test-http2-client-destroy.js
128ca3e
PR-URL: #49820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in
c22d9bb
PR-URL: nodejs/node#49820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in
6ecf529
PR-URL: nodejs/node#49820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessentniessentniessen left review comments
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@niyashiyas@tniessen@nodejs-github-bot@lpinca