Skip to content

test: replace forEach with for..of in test-net-isipv4.js - #49822

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
niyashiyas:test-6
Oct 21, 2023
Merged

test: replace forEach with for..of in test-net-isipv4.js#49822
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
niyashiyas:test-6

Conversation

@niyashiyas

@niyashiyasniyashiyas commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

test: Replaced forEach with for..of in test-net-isipv4.js

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2023
tniessen
tniessen reviewed Sep 23, 2023
View reviewed changes
Comment threadtest/parallel/test-net-isipv4.js Outdated

@tniessentniessenSep 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
}

@niyashiyasniyashiyasSep 24, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made required changes.

Comment threadtest/parallel/test-net-isipv4.js Outdated
@tniessentniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
@niyashiyas

niyashiyas commented Sep 24, 2023

Copy link
Copy Markdown
ContributorAuthor

Please review again.

@niyashiyasniyashiyas changed the title test: Replaced forEach with for..of in test-net-isipv4.jstest: replace forEach with for..of in test-net-isipv4.jsSep 30, 2023
lpinca
lpinca approved these changes Oct 9, 2023
View reviewed changes
Comment threadtest/parallel/test-net-isipv4.js Outdated
Comment threadtest/parallel/test-net-isipv4.js Outdated
@lpincalpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 9, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54636/

This was referenced Oct 10, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54969/

@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55078/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b084b26 into nodejs:mainOct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in b084b26

targos pushed a commit that referenced this pull request Oct 23, 2023
@niyashiyas@targos
test: replace forEach with for..of in test-net-isipv4.js
67c599e
PR-URL: #49822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas@targos
test: replace forEach with for..of in test-net-isipv4.js
379a725
PR-URL: #49822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@niyashiyas@targos
test: replace forEach with for..of in test-net-isipv4.js
2f0ffde
PR-URL: #49822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Nov 28, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in test-net-isipv4.js
2273c9e
PR-URL: nodejs/node#49822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in test-net-isipv4.js
4d0d987
PR-URL: nodejs/node#49822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@niyashiyas@nodejs-github-bot@lpinca@tniessen