[deps/zlib]: Fixed cpu-features.h not found during building for Android aarch64 by MatteoBax · Pull Request #49828 · nodejs/node

MatteoBax · 2023-09-23T14:31:45Z

I fixed cpu-features.h not found during building for Android aarch64 but now the building problems are:


../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:49:21: error: call to undeclared function 'ntohs'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return (int64_t)ntohs(n.n16);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:53:21: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return (int64_t)ntohl(n.n32);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:69:7: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = nghttp3_htonl64(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:73:32: note: expanded from macro 'nghttp3_htonl64'
# define nghttp3_htonl64(N) nghttp3_bswap64(N)
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:60:17: note: expanded from macro 'nghttp3_bswap64'
((uint64_t)(ntohl((uint32_t)(N))) << 32 | ntohl((uint32_t)((N) >> 32)))
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:74:7: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = nghttp3_htonl64(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:73:32: note: expanded from macro 'nghttp3_htonl64'
# define nghttp3_htonl64(N) nghttp3_bswap64(N)
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:60:17: note: expanded from macro 'nghttp3_bswap64'
((uint64_t)(ntohl((uint32_t)(N))) << 32 | ntohl((uint32_t)((N) >> 32)))
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:79:7: error: call to undeclared function 'htonl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = htonl(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:84:7: error: call to undeclared function 'htonl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = htonl(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:89:7: error: call to undeclared function 'htons'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = htons(n);
^
7 errors generated.

To solve this problem I created an environment variable called NDK_PATH that points to the ndk installation folder.
In the common.gypi file I added another argument to cflags which contains the path to the cpu-features.h file.

I changed only release configuration.

nodejs-github-bot · 2023-09-23T14:31:49Z

Review requested:

@nodejs/gyp

bnoordhuis · 2023-09-23T15:37:53Z

Thanks for the pull request. I don't think it's appropriate to modify the user's .bashrc, and using shell syntax in the build scripts is suboptimal, but what you can do instead is:

print an error in android_configure when NDK_PATH is unset
add it as (for example) android_ndk_path=... to GYP_DEFINES
use -I<(android_ndk_path)/sources/android/cpufeatures syntax in the gyp file

MatteoBax · 2023-09-23T16:01:56Z

I've done.

nodejs-github-bot · 2023-09-23T19:23:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54182/

MatteoBax · 2023-09-25T20:06:30Z

How do I change the first commit message?
If I don't change it, it's not possible to merge the pull request.

lpinca · 2023-09-25T20:10:17Z

@MatteoBax rebase and force push.

bnoordhuis · 2023-09-28T17:39:15Z

@MatteoBax try rebase + squash (git rebase -i) + force-push instead of merge

MatteoBax · 2023-09-28T19:27:28Z

I've done.

bnoordhuis · 2023-09-28T19:34:41Z

Can you squash into a single commit? I still count 6.

MatteoBax · 2023-09-28T19:46:35Z

I just squashed in a single commit.

nodejs-github-bot · 2023-09-28T20:29:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54340/

zongou · 2023-09-28T21:54:02Z

In case you encounter anymore problem building for android, check out my this action.

MatteoBax · 2023-09-29T07:32:14Z

In case you encounter anymore problem building for android, check out my this action.

Ok

MatteoBax · 2023-09-29T07:33:07Z

What shall I do that node-test-commit, node-test-commit-osx and node-test-pull-request checks failed?

richardlau · 2023-09-29T11:18:47Z

What shall I do that node-test-commit, node-test-commit-osx and node-test-pull-request checks failed?

@MatteoBax the node-test-commit-osx build failed because while it was queued to run this PR was force pushed and git removed the old commit that the check was scheduled to run on.

One of those force pushes has introduced additional unrelated changes to this PR to tools/osx-notarize.sh. If you could undo those changes I can restart the CI runs -- once we've started CI runs please do not update the PR unless asked to do so as every new commit or force push would require us to restart the CI runs from the beginning again.

zlib: fixes#49766 fixed cpu-features.h not found issue Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>

MatteoBax · 2023-09-29T12:35:41Z

I've done.
It was my mistake, sorry.

nodejs-github-bot · 2023-09-29T12:39:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54368/

nodejs-github-bot · 2023-09-29T15:27:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54377/

Fixed cpu-features.h not found issue. Co-Authored-By: Luigi Pinca <luigipinca@gmail.com> Fixes: #49766 PR-URL: #49828 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

richardlau · 2023-09-29T16:05:15Z

Landed in 16ac5e1.

MatteoBax · 2023-09-29T20:41:46Z

In case you encounter anymore problem building for android, check out my this action.

If i add -Wno-implicit-function-declaration option to cflags these problems disappear.Did you do this too?


../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:49:21: error: call to undeclared function 'ntohs'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return (int64_t)ntohs(n.n16);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:53:21: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return (int64_t)ntohl(n.n32);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:69:7: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = nghttp3_htonl64(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:73:32: note: expanded from macro 'nghttp3_htonl64'
# define nghttp3_htonl64(N) nghttp3_bswap64(N)
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:60:17: note: expanded from macro 'nghttp3_bswap64'
((uint64_t)(ntohl((uint32_t)(N))) << 32 | ntohl((uint32_t)((N) >> 32)))
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:74:7: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = nghttp3_htonl64(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:73:32: note: expanded from macro 'nghttp3_htonl64'
# define nghttp3_htonl64(N) nghttp3_bswap64(N)
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:60:17: note: expanded from macro 'nghttp3_bswap64'
((uint64_t)(ntohl((uint32_t)(N))) << 32 | ntohl((uint32_t)((N) >> 32)))
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:79:7: error: call to undeclared function 'htonl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = htonl(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:84:7: error: call to undeclared function 'htonl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = htonl(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:89:7: error: call to undeclared function 'htons'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = htons(n);
^
7 errors generated.

The next problems are:

../deps/v8/src/base/debug/stack_trace_posix.cc:156:9: error: use of undeclared identifier 'backtrace_symbols'
backtrace_symbols(trace, static_cast<int>(size)));
^
../deps/v8/src/base/debug/stack_trace_posix.cc:371:32: error: use of undeclared identifier 'backtrace'; did you mean 'StackTrace'?
count_ = static_cast<size_t>(backtrace(trace_, arraysize(trace_)));
^
../deps/v8/src/base/debug/stack_trace.h:41:22: note: 'StackTrace' declared here
class V8_BASE_EXPORT StackTrace {
^
2 errors generated.

How did you fix them?

I can only compile with your workflow.

@zongou I think it's best if you open a pull request to resolve these issues.

zongou · 2023-09-29T22:43:10Z

In case you encounter anymore problem building for android, check out my this action.

If i add -Wno-implicit-function-declaration option to cflags these problems disappear.Did you do this too?


../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:49:21: error: call to undeclared function 'ntohs'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return (int64_t)ntohs(n.n16);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:53:21: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
return (int64_t)ntohl(n.n32);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:69:7: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = nghttp3_htonl64(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:73:32: note: expanded from macro 'nghttp3_htonl64'
# define nghttp3_htonl64(N) nghttp3_bswap64(N)
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:60:17: note: expanded from macro 'nghttp3_bswap64'
((uint64_t)(ntohl((uint32_t)(N))) << 32 | ntohl((uint32_t)((N) >> 32)))
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:74:7: error: call to undeclared function 'ntohl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = nghttp3_htonl64(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:73:32: note: expanded from macro 'nghttp3_htonl64'
# define nghttp3_htonl64(N) nghttp3_bswap64(N)
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.h:60:17: note: expanded from macro 'nghttp3_bswap64'
((uint64_t)(ntohl((uint32_t)(N))) << 32 | ntohl((uint32_t)((N) >> 32)))
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:79:7: error: call to undeclared function 'htonl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = htonl(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:84:7: error: call to undeclared function 'htonl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = htonl(n);
^
../deps/ngtcp2/nghttp3/lib/nghttp3_conv.c:89:7: error: call to undeclared function 'htons'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
n = htons(n);
^
7 errors generated.

The next problems are:

../deps/v8/src/base/debug/stack_trace_posix.cc:156:9: error: use of undeclared identifier 'backtrace_symbols'
backtrace_symbols(trace, static_cast<int>(size)));
^
../deps/v8/src/base/debug/stack_trace_posix.cc:371:32: error: use of undeclared identifier 'backtrace'; did you mean 'StackTrace'?
count_ = static_cast<size_t>(backtrace(trace_, arraysize(trace_)));
^
../deps/v8/src/base/debug/stack_trace.h:41:22: note: 'StackTrace' declared here
class V8_BASE_EXPORT StackTrace {
^
2 errors generated.

How did you fix them?

I can only compile with your workflow.

@zongou I think it's best if you open a pull request to resolve these issues.

i did not encounter this problem, i guess this step have skipped this problem

echo> test/cctest/test_crypto_clienthello.cc

Fixed cpu-features.h not found issue. Co-Authored-By: Luigi Pinca <luigipinca@gmail.com> Fixes: #49766 PR-URL: #49828 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Fixed cpu-features.h not found issue. Co-Authored-By: Luigi Pinca <luigipinca@gmail.com> Fixes: nodejs#49766 PR-URL: nodejs#49828 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Sep 23, 2023

This comment was marked as off-topic.
Sign in to view

bnoordhuis approved these changes Sep 23, 2023
View reviewed changes

lpinca approved these changes Sep 23, 2023
View reviewed changes

Comment threadandroid_configure.py Outdated

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2023

MatteoBax changed the title ~~Fixed cpu-features.h not found during building for Android aarch64~~[deps/zlib]: Fixed cpu-features.h not found during building for Android aarch64Sep 24, 2023

richardlau approved these changes Sep 24, 2023
View reviewed changes

richardlau approved these changes Sep 28, 2023
View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2023

zlib:fixes#49766
df5dd64
zlib: fixes#49766 fixed cpu-features.h not found issue Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023

richardlau approved these changes Sep 29, 2023
View reviewed changes

richardlau closed this Sep 29, 2023

This was referenced Sep 30, 2023
CI Reliability 2023-09-30 nodejs/reliability#679
Open
CI Reliability 2023-10-01 nodejs/reliability#680
Open
CI Reliability 2023-10-02 nodejs/reliability#681
Open

RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged

targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged

juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged

Uh oh!

Uh oh!

Conversation

MatteoBax commented Sep 23, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 23, 2023

Uh oh!

bnoordhuis commented Sep 23, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MatteoBax commented Sep 23, 2023

Uh oh!

This comment was marked as off-topic.

Uh oh!

nodejs-github-bot commented Sep 23, 2023

Uh oh!

MatteoBax commented Sep 25, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lpinca commented Sep 25, 2023

Uh oh!

bnoordhuis commented Sep 28, 2023

Uh oh!

MatteoBax commented Sep 28, 2023

Uh oh!

bnoordhuis commented Sep 28, 2023

Uh oh!

MatteoBax commented Sep 28, 2023

Uh oh!

nodejs-github-bot commented Sep 28, 2023

Uh oh!

zongou commented Sep 28, 2023

Uh oh!

MatteoBax commented Sep 29, 2023

Uh oh!

MatteoBax commented Sep 29, 2023

Uh oh!

richardlau commented Sep 29, 2023

Uh oh!

MatteoBax commented Sep 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 29, 2023

Uh oh!

nodejs-github-bot commented Sep 29, 2023

Uh oh!

richardlau commented Sep 29, 2023

Uh oh!

MatteoBax commented Sep 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zongou commented Sep 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MatteoBax commented Sep 23, 2023•
edited
Loading

bnoordhuis commented Sep 23, 2023•
edited
Loading

MatteoBax commented Sep 25, 2023•
edited
Loading

MatteoBax commented Sep 29, 2023•
edited
Loading

MatteoBax commented Sep 29, 2023•
edited
Loading